Skip to content

Handle pre-contest clarifications #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Handle pre-contest clarifications #3174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0071234
Warn jury for clarifications before contest start
vmcj Oct 26, 2025
d54c96e
Prevent clarifications before the contest without explicit time
vmcj Oct 26, 2025
4706e75
Display pre-contest clarifications
vmcj Oct 26, 2025
1f77c9a
Allow teams to request clarifications before the contest
vmcj Oct 26, 2025
8342cf2
Don't display clarification time from before contest
vmcj Oct 26, 2025
c8c97ec
Don't reference undisclosed problems in clarifications before contest…
vmcj Oct 26, 2025
3a60f88
Don't display clarifications about non-disclosed problems yet
vmcj Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions webapp/templates/team/partials/clarifications_team.html.twig
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather reject clar requests before contest start through the API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of letting teams ask them via UI (because they can via API) disallow both via UI & API?

I think I'm fine with that, I want the jury to still be able to send them via API because of imports and suspected we didn't want the extra branch. I did not really like having to add this to the UI but found consistency important.

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{% if clarifications is not empty or always_display %}
<h1 class="teamoverview">Clarifications</h1>
{% if clarifications is empty %}
<p class="nodata">No clarifications.</p>
{% else %}
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %}
{% endif %}
{% endif %}

<h1 class="teamoverview">Clarification Requests</h1>
{% if clarificationRequests is empty %}
<p class="nodata">No clarification request.</p>
{% else %}
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarificationRequests} %}
{% endif %}

<div class="m-1">
<a href="{{ path('team_clarification_add') }}" class="btn btn-secondary btn-sm" data-ajax-modal data-ajax-modal-after="initModalClarificationPreviewAdd">
Request clarification
</a>
</div>

27 changes: 4 additions & 23 deletions webapp/templates/team/partials/index_content.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
<h2 id="contestnotstarted" class="text-center">
Contest {{ contest | printContestStart }}
</h2>
{% if clarifications is not empty %}
<h1 class="teamoverview">Clarifications</h1>
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %}
{% endif %}

{% include 'team/partials/clarifications_team.html.twig' with {'always_display': false} %}
{% else %}

<div id="teamscoresummary">
Expand All @@ -30,26 +28,9 @@

{% include 'team/partials/submission_list.html.twig' %}
</div>
<div class="col">
<h1 class="teamoverview">Clarifications</h1>
{% if clarifications is empty %}
<p class="nodata">No clarifications.</p>
{% else %}
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %}
{% endif %}

<h1 class="teamoverview">Clarification Requests</h1>
{% if clarificationRequests is empty %}
<p class="nodata">No clarification request.</p>
{% else %}
{% include 'team/partials/clarification_list.html.twig' with {clarifications: clarificationRequests} %}
{% endif %}

<div class="m-1">
<a href="{{ path('team_clarification_add') }}" class="btn btn-secondary btn-sm" data-ajax-modal data-ajax-modal-after="initModalClarificationPreviewAdd">
Request clarification
</a>
</div>
<div class="col">
{% include 'team/partials/clarifications_team.html.twig' with {'always_display': true} %}
</div>
</div>
{% endif %}
Expand Down