Skip to content

Conversation

@vmcj
Copy link
Member

@vmcj vmcj commented Nov 13, 2025

Closes: #3048

Originally I wanted to just pick the one contest in case there is only one as you typically enter this situation by fixing a failed import. But as I'm not sure if we should choose for the user even if it works in 99% of the cases the 2nd is maybe better.

@nickygerritsen
Copy link
Member

I agree that this is better

@vmcj
Copy link
Member Author

vmcj commented Nov 13, 2025

I agree that this is better

I provided 2 options, I'll assume you want the 2nd.

@nickygerritsen
Copy link
Member

Yes, thisPR is what I meant

In 99% of the cases the user wants the last added contest but we choose to make
that choice explicit to prevent importing problems into the wrong contest.
@vmcj vmcj force-pushed the contest_import_1_contest branch from 5e8fbc7 to 8cf722c Compare November 13, 2025 18:17
@vmcj vmcj enabled auto-merge November 13, 2025 18:17
@vmcj vmcj added this pull request to the merge queue Nov 13, 2025
Merged via the queue into DOMjudge:main with commit 26aeefa Nov 13, 2025
37 checks passed
@vmcj vmcj deleted the contest_import_1_contest branch November 13, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import-contest should not ask contest-id if there is only 1

3 participants