-
Notifications
You must be signed in to change notification settings - Fork 0
Johnfreeman/prep release merged #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcrone/pds schema fix
Updated trigger candidate maker configuration schema
Update release
Revert "Updated trigger candidate maker configuration schema"
Contributor
Author
|
n.b. The reason for the single repo CI workflow failure isn't due to the code itself, but because the fact that there's a |
andrewmogan
approved these changes
Dec 15, 2025
Contributor
andrewmogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
fddaq-v5.5.0now cut, this source branch consists of a fork of thedevelopbranch withprep-release/fddaq-v5.5.0merged in (i.e., this will be a fast-forward merge which brings thefddaq-v5.5.0code intodevelop). Over the weekend a test nightly was created,MRGFD_DEV_251213_A9, in which all thejohnfreeman/prep_release_mergedbranches were used, and if Ipip install -U .thejohnfreeman/prep_release_mergedbranch ofdrunc, integration tests with it look fine.Description
If full decription and testing details are included on a parent issue, please link to that here.
See issue # for details
Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.
Addresses issue #
Please also include instructions for how a reviewer can test your changes.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))