Skip to content

Conversation

@PawelPlesniak
Copy link
Collaborator

@PawelPlesniak PawelPlesniak commented Dec 10, 2025

Description

Fixes #702

Includes basic checks for the root controller and local connectivity service applications, and points the user to the commands that should be run to address this.

Changelog

Prior to instantiating the stateful node, the unified shell parses out the root controller address and LCS address to validate that they are not yet in use.

Suggested testing methods

On the same physical host run

drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config FirstInstanceOfSession

then in a separate tty run

drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config SecondInstanceOfSession

This will give you logs such as

[2025/12/10 16:36:18] CRITICAL   shell.py:192                   unified_shell:                                Current root controller address (localhost:32336) is already in use. Use script daqconf_set_rc_controller_port on your configuration file to change the root controller port   
                                 first! 

It is suggested for the reviewer to start all the possible flavours of the process managers.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@PawelPlesniak
Copy link
Collaborator Author

Note - this has not been marked as "Ready for review" as the archiecture behind the integration tests that start the LCS separately has not yet been understood, hence all integration tests that start their own LCS fail. This will be corrected, but until then, this PR is on hold

Base automatically changed from prep-release/fddaq-v5.5.0 to develop December 15, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants