Added a DAQ session overall time measurement to the integrationtest results… #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that are passed back to users so that it can be used for fine-tuning ranges in various time-based checks on the results of the test.
Description
This PR is correlated with a PR in the
daqsystemtestrepo, specifically DUNE-DAQ/daqsystemtest#276.The changes in this repo are rather straightforward: measuring the overall wallclock time that is spent running the DAQ session and passing that value back to the user in the RunResults structure.
This change was prompted by a recent failure in the number-of-metric-samples validation check in
daqsystemtest/minimal_system_quick_test.sh. Instead of an expected 3 metric samples in that test, 6 metric samples were observed. The extra samples were caused by a longer-than-normal run time of the DAQ session. (I'm not sure which DAQ transition took longer than normal, nor why that may have happened.)Here are suggestions for testing these changes in conjunction with the ones in
daqsystemtest:Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)Further checks