Skip to content

additional checks for pointer validity #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MRiganSUSX wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

additional checks for pointer validity #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c9b5b
additional checks for pointer validity
MRiganSUSX Mar 11, 2025
2c3a04f
Merge branch 'develop' into mrigan/factory_check
MRiganSUSX Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/triggeralgs/AbstractFactory.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ template <typename T>
void AbstractFactory<T>::register_creator(const std::string alg_name, maker_creator creator)
{
creation_map& makers = get_makers();

// Check invalid state in the map
for (const auto& pair : makers) {
if (!pair.second) { // nullptr or invalid
throw FactoryInvalidState(ERS_HERE, alg_name);
}
}

auto it = makers.find(alg_name);

if (it == makers.end()) {
Expand Down
5 changes: 5 additions & 0 deletions include/triggeralgs/Issues.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ ERS_DECLARE_ISSUE(triggeralgs,
"Attempted to overwrite a creator in factory with " << alg_name,
((std::string)alg_name))

ERS_DECLARE_ISSUE(triggeralgs,
FactoryInvalidState,
"Makers map contains invalid/null pointers " << alg_name,
((std::string)alg_name))

ERS_DECLARE_ISSUE(triggeralgs,
FactoryNotFound,
"Factory couldn't find: " << alg_name,
Expand Down