Skip to content

fix issue #42 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue #42 #43

wants to merge 2 commits into from

Conversation

c-xk
Copy link

@c-xk c-xk commented Jun 1, 2025 •
edited
Loading

After this PR, the gsettings process will terminate properly after the application exits.
#42

Dansoftowner
Dansoftowner requested changes Jun 1, 2025
View reviewed changes
Copy link
Owner

@Dansoftowner Dansoftowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your work!

However I need some adjustments!

  • Please remove the noisy 'System.out.println' statements (e.g. on line 109 and line 193) .
  • Please remove all the non-english comments

@c-xk
Copy link
Author

c-xk commented Jun 1, 2025

Alright, I’ve removed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dansoftowner Dansoftowner Dansoftowner requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-xk @Dansoftowner