-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Dump JVM output when bazel fails on Windows
#41844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump JVM output when bazel fails on Windows
#41844
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 9debed3 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | % cpu utilization | -23.93 | [-25.56, -22.31] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_memory | memory utilization | +2.21 | [+1.68, +2.75] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +2.19 | [-0.60, +4.97] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.99 | [+0.86, +1.12] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.98 | [+0.77, +1.19] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.98 | [+0.91, +1.05] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.54 | [+0.34, +0.74] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.49 | [+0.45, +0.53] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.33 | [+0.27, +0.39] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.21 | [+0.04, +0.38] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.20 | [+0.16, +0.24] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.13 | [-0.52, +0.78] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.09 | [-0.04, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.07 | [-0.56, +0.70] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.07 | [-0.06, +0.20] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.04 | [+0.00, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.63, +0.67] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.22, +0.24] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.01 | [-0.03, +0.04] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.58, +0.57] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.05 | [-0.20, +0.10] | 1 | Logs |
| ✅ | docker_containers_cpu | % cpu utilization | -23.93 | [-25.56, -22.31] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
c04844e to
737dd8b
Compare
This is to diagnose recurring: ``` Starting local Bazel server (8.3.1) and connecting to it... ... still trying to connect to local Bazel server (45008) after 10 seconds ... ... still trying to connect to local Bazel server (45008) after 20 seconds ... ... still trying to connect to local Bazel server (45008) after 30 seconds ... ... still trying to connect to local Bazel server (45008) after 40 seconds ... ... still trying to connect to local Bazel server (45008) after 50 seconds ... ... still trying to connect to local Bazel server (45008) after 60 seconds ... ... still trying to connect to local Bazel server (45008) after 70 seconds ... ... still trying to connect to local Bazel server (45008) after 80 seconds ... ... still trying to connect to local Bazel server (45008) after 90 seconds ... ... still trying to connect to local Bazel server (45008) after 100 seconds ... ... still trying to connect to local Bazel server (45008) after 110 seconds ... FATAL: couldn't connect to server (45008) after 120 seconds. ``` The change hopefully provides more actionable material when it happens. There's no need to wait for 2 minutes prior to bailing out, so decreasing to 30 seconds will probably allow us to reproduce more frequently. Also, we'll print any running `bazel.exe` or `java.exe` before and after the `bazel` command to know whether there should be additional cleanup to consider adding.
737dd8b to
07c3053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH. I have no idea if this is correct, but I'm willing to believe you.
@aiuto Thanks for the trust. Happy to walk through. |
### What does this PR do? CI diagnostics for failed `bazel` builds on Windows didn't work as expected (see #41844 for more details). The change consists in: - removing the pseudo-shebang that was preventing from resolving paths relative to the source script's location, - making sure the output is UTF-8 (`chcp 65001`) to echo non-ASCII characters from dumped contents, - using the right `bazel` startup flag (`--local_startup_timeout_secs`) to limit the total retry loop to 30s, while making the retries more frequent (`--connect_timeout_secs`) inside the loop, - no longer assuming `$CI_PROJECT_DIR` resolves to the workspace's root, - payload: fixing/discovering base location for server logs which happen to be under a subdirectory whose name is a hash (`jgkidtko` on my VM). ### Motivation Really get actionable outputs for addressing `FATAL: couldn't connect to server` errors. ### Describe how you validated your changes Reproduced CI layout locally and fixed the script to make it provide with available info on `bazel` build failures. ### Additional Notes This is of course temporary until we figure out what's preventing the `bazel` CLI from contacting the server.
What does this PR do?
This is to diagnose recurring:
Motivation
The change hopefully provides more actionable material when it happens, see #incident-42947.
Additional Notes
There's no need to wait for 2 minutes prior to bailing out, so decreasing to 30 seconds will probably allow us to reproduce more frequently.
Also, we'll print any running
bazel.exeorjava.exebefore and after thebazelcommand to know whether there should be additional cleanup to consider adding.