Skip to content

Conversation

@marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Nov 24, 2025

What does this PR do?

Adds new attributes to the Device Info:

  • totalRam: The total RAM in megabytes
  • processorCount: Number of device processors
  • isLowRamDevice: Whether the device is considered a low RAM device (from ActivityManager.isLowRamDevice)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-12199/new-device-capability-metrics branch 2 times, most recently from a5339c4 to 899ef0f Compare November 24, 2025 15:07
@marco-saia-datadog marco-saia-datadog changed the title [FEAT] Added 'totalRam', 'processorCount' and 'isLowRamDevice' to DeviceInfo RUM-12199: Added 'totalRam', 'processorCount' and 'isLowRamDevice' to DeviceInfo Nov 24, 2025
@marco-saia-datadog marco-saia-datadog changed the title RUM-12199: Added 'totalRam', 'processorCount' and 'isLowRamDevice' to DeviceInfo RUM-12199: Add 'totalRam', 'processorCount' and 'isLowRamDevice' to DeviceInfo Nov 24, 2025
@marco-saia-datadog marco-saia-datadog changed the title RUM-12199: Add 'totalRam', 'processorCount' and 'isLowRamDevice' to DeviceInfo RUM-12199: Add totalRam, processorCount and isLowRamDevice to DeviceInfo Nov 24, 2025
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-12199/new-device-capability-metrics branch 2 times, most recently from 65945bf to 55a5484 Compare November 24, 2025 15:35
@datadog-official
Copy link

datadog-official bot commented Nov 24, 2025

🎯 Code Coverage
Patch Coverage: 76.92%
Total Coverage: 71.30% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c356214 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 78.65169% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.11%. Comparing base (ac0c5d5) to head (c356214).

Files with missing lines Patch % Lines
...core/internal/system/DefaultAndroidInfoProvider.kt 18.75% 13 Missing ⚠️
...tadog/android/core/internal/NoOpContextProvider.kt 0.00% 3 Missing ⚠️
...id/core/internal/system/NoOpAndroidInfoProvider.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3024      +/-   ##
===========================================
- Coverage    71.17%   71.11%   -0.06%     
===========================================
  Files          859      859              
  Lines        31453    31526      +73     
  Branches      5305     5305              
===========================================
+ Hits         22384    22417      +33     
- Misses        7563     7593      +30     
- Partials      1506     1516      +10     
Files with missing lines Coverage Δ
...tlin/com/datadog/android/api/context/DeviceInfo.kt 100.00% <100.00%> (ø)
...og/android/core/internal/DatadogContextProvider.kt 98.25% <100.00%> (+0.10%) ⬆️
...android/log/internal/domain/DatadogLogGenerator.kt 98.02% <100.00%> (+0.03%) ⬆️
...g/android/rum/internal/DatadogLateCrashReporter.kt 85.57% <100.00%> (-0.82%) ⬇️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 96.59% <100.00%> (+0.05%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 91.12% <100.00%> (+0.45%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.12% <100.00%> (-0.01%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 85.37% <100.00%> (+0.24%) ⬆️
...trace/internal/domain/event/BaseSpanEventMapper.kt 70.45% <100.00%> (+7.04%) ⬆️
...tadog/android/core/internal/NoOpContextProvider.kt 2.08% <0.00%> (-0.14%) ⬇️
... and 2 more

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-12199/new-device-capability-metrics branch from 55a5484 to c356214 Compare December 1, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants