-
Notifications
You must be signed in to change notification settings - Fork 319
Enabling optimized map by default #10016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050884
Total [baseline] (8.708 s) : 0, 8708049
Agent [candidate] (1.05 s) : 0, 1050191
Total [candidate] (8.685 s) : 0, 8684835
section iast
Agent [baseline] (1.197 s) : 0, 1197136
Total [baseline] (9.306 s) : 0, 9306154
Agent [candidate] (1.19 s) : 0, 1189578
Total [candidate] (9.355 s) : 0, 9354795
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (706.877 ms) : 0, 706877
BytebuddyAgent [candidate] (705.847 ms) : 0, 705847
GlobalTracer [baseline] (248.365 ms) : 0, 248365
GlobalTracer [candidate] (248.676 ms) : 0, 248676
AppSec [baseline] (31.863 ms) : 0, 31863
AppSec [candidate] (32.0 ms) : 0, 32000
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.359 ms) : 0, 6359
Remote Config [baseline] (667.499 µs) : 0, 667
Remote Config [candidate] (672.792 µs) : 0, 673
Telemetry [baseline] (15.29 ms) : 0, 15290
Telemetry [candidate] (15.447 ms) : 0, 15447
Flare Poller [baseline] (4.868 ms) : 0, 4868
Flare Poller [candidate] (4.836 ms) : 0, 4836
section iast
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (836.985 ms) : 0, 836985
BytebuddyAgent [candidate] (828.678 ms) : 0, 828678
GlobalTracer [baseline] (236.83 ms) : 0, 236830
GlobalTracer [candidate] (237.074 ms) : 0, 237074
IAST [baseline] (30.08 ms) : 0, 30080
IAST [candidate] (30.07 ms) : 0, 30070
AppSec [baseline] (31.303 ms) : 0, 31303
AppSec [candidate] (31.72 ms) : 0, 31720
Debugger [baseline] (6.127 ms) : 0, 6127
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (612.963 µs) : 0, 613
Remote Config [candidate] (625.45 µs) : 0, 625
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (8.031 ms) : 0, 8031
Flare Poller [baseline] (10.679 ms) : 0, 10679
Flare Poller [candidate] (10.863 ms) : 0, 10863
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062223
Total [baseline] (10.844 s) : 0, 10844464
Agent [candidate] (1.054 s) : 0, 1053827
Total [candidate] (10.825 s) : 0, 10824761
section appsec
Agent [baseline] (1.233 s) : 0, 1233293
Total [baseline] (10.915 s) : 0, 10914853
Agent [candidate] (1.227 s) : 0, 1226904
Total [candidate] (10.931 s) : 0, 10931365
section iast
Agent [baseline] (1.193 s) : 0, 1193442
Total [baseline] (11.178 s) : 0, 11177700
Agent [candidate] (1.193 s) : 0, 1192931
Total [candidate] (11.117 s) : 0, 11117287
section profiling
Agent [baseline] (1.202 s) : 0, 1202135
Total [baseline] (10.909 s) : 0, 10909059
Agent [candidate] (1.205 s) : 0, 1204952
Total [candidate] (10.942 s) : 0, 10942467
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (714.279 ms) : 0, 714279
BytebuddyAgent [candidate] (708.405 ms) : 0, 708405
GlobalTracer [baseline] (251.271 ms) : 0, 251271
GlobalTracer [candidate] (249.491 ms) : 0, 249491
AppSec [baseline] (32.493 ms) : 0, 32493
AppSec [candidate] (31.984 ms) : 0, 31984
Debugger [baseline] (6.492 ms) : 0, 6492
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (683.24 µs) : 0, 683
Remote Config [candidate] (681.366 µs) : 0, 681
Telemetry [baseline] (14.747 ms) : 0, 14747
Telemetry [candidate] (15.618 ms) : 0, 15618
Flare Poller [baseline] (5.756 ms) : 0, 5756
Flare Poller [candidate] (4.916 ms) : 0, 4916
section appsec
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (735.52 ms) : 0, 735520
BytebuddyAgent [candidate] (731.355 ms) : 0, 731355
GlobalTracer [baseline] (241.707 ms) : 0, 241707
GlobalTracer [candidate] (240.378 ms) : 0, 240378
IAST [baseline] (24.79 ms) : 0, 24790
IAST [candidate] (24.695 ms) : 0, 24695
AppSec [baseline] (175.361 ms) : 0, 175361
AppSec [candidate] (174.741 ms) : 0, 174741
Debugger [baseline] (6.361 ms) : 0, 6361
Debugger [candidate] (6.379 ms) : 0, 6379
Remote Config [baseline] (709.591 µs) : 0, 710
Remote Config [candidate] (692.524 µs) : 0, 693
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.146 ms) : 0, 8146
Flare Poller [baseline] (4.062 ms) : 0, 4062
Flare Poller [candidate] (4.087 ms) : 0, 4087
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (831.684 ms) : 0, 831684
BytebuddyAgent [candidate] (831.838 ms) : 0, 831838
GlobalTracer [baseline] (238.11 ms) : 0, 238110
GlobalTracer [candidate] (237.86 ms) : 0, 237860
IAST [baseline] (30.072 ms) : 0, 30072
IAST [candidate] (30.848 ms) : 0, 30848
AppSec [baseline] (31.677 ms) : 0, 31677
AppSec [candidate] (30.696 ms) : 0, 30696
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (606.685 µs) : 0, 607
Remote Config [candidate] (604.161 µs) : 0, 604
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.98 ms) : 0, 7980
Flare Poller [baseline] (10.749 ms) : 0, 10749
Flare Poller [candidate] (10.734 ms) : 0, 10734
section profiling
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (736.243 ms) : 0, 736243
BytebuddyAgent [candidate] (738.228 ms) : 0, 738228
GlobalTracer [baseline] (222.946 ms) : 0, 222946
GlobalTracer [candidate] (223.844 ms) : 0, 223844
AppSec [baseline] (32.23 ms) : 0, 32230
AppSec [candidate] (32.308 ms) : 0, 32308
Debugger [baseline] (8.537 ms) : 0, 8537
Debugger [candidate] (7.648 ms) : 0, 7648
Remote Config [baseline] (700.903 µs) : 0, 701
Remote Config [candidate] (1.472 ms) : 0, 1472
Telemetry [baseline] (14.692 ms) : 0, 14692
Telemetry [candidate] (14.707 ms) : 0, 14707
Flare Poller [baseline] (4.198 ms) : 0, 4198
Flare Poller [candidate] (4.241 ms) : 0, 4241
ProfilingAgent [baseline] (111.552 ms) : 0, 111552
ProfilingAgent [candidate] (111.583 ms) : 0, 111583
Profiling [baseline] (112.196 ms) : 0, 112196
Profiling [candidate] (112.242 ms) : 0, 112242
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section baseline
no_agent (18.015 ms) : 17835, 18195
. : milestone, 18015,
appsec (19.703 ms) : 19502, 19905
. : milestone, 19703,
code_origins (17.903 ms) : 17725, 18081
. : milestone, 17903,
iast (17.841 ms) : 17664, 18019
. : milestone, 17841,
profiling (19.11 ms) : 18917, 19303
. : milestone, 19110,
tracing (17.369 ms) : 17197, 17541
. : milestone, 17369,
section candidate
no_agent (18.219 ms) : 18029, 18410
. : milestone, 18219,
appsec (18.775 ms) : 18584, 18966
. : milestone, 18775,
code_origins (17.894 ms) : 17716, 18071
. : milestone, 17894,
iast (19.452 ms) : 19257, 19647
. : milestone, 19452,
profiling (18.645 ms) : 18457, 18833
. : milestone, 18645,
tracing (17.521 ms) : 17351, 17692
. : milestone, 17521,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.314 ms) : 3265, 3364
. : milestone, 3314,
iast_FULL (5.859 ms) : 5801, 5917
. : milestone, 5859,
iast_GLOBAL (3.67 ms) : 3613, 3727
. : milestone, 3670,
profiling (1.998 ms) : 1981, 2015
. : milestone, 1998,
tracing (1.795 ms) : 1780, 1809
. : milestone, 1795,
section candidate
no_agent (1.198 ms) : 1187, 1209
. : milestone, 1198,
iast (3.248 ms) : 3207, 3288
. : milestone, 3248,
iast_FULL (5.901 ms) : 5841, 5960
. : milestone, 5901,
iast_GLOBAL (3.65 ms) : 3583, 3717
. : milestone, 3650,
profiling (2.017 ms) : 1998, 2036
. : milestone, 2017,
tracing (1.807 ms) : 1792, 1822
. : milestone, 1807,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section baseline
no_agent (15.454 s) : 15454000, 15454000
. : milestone, 15454000,
appsec (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
iast (18.467 s) : 18467000, 18467000
. : milestone, 18467000,
iast_GLOBAL (17.799 s) : 17799000, 17799000
. : milestone, 17799000,
profiling (14.701 s) : 14701000, 14701000
. : milestone, 14701000,
tracing (14.652 s) : 14652000, 14652000
. : milestone, 14652000,
section candidate
no_agent (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
appsec (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
iast (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
. : milestone, 18020000,
profiling (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b36dbbb530, baseline=1.57.0-SNAPSHOT~6bbe0531a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.478 ms) : 2425, 2531
. : milestone, 2478,
iast (2.226 ms) : 2160, 2291
. : milestone, 2226,
iast_GLOBAL (2.269 ms) : 2203, 2335
. : milestone, 2269,
profiling (2.499 ms) : 2337, 2660
. : milestone, 2499,
tracing (2.062 ms) : 2010, 2113
. : milestone, 2062,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (2.474 ms) : 2421, 2527
. : milestone, 2474,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.268 ms) : 2202, 2334
. : milestone, 2268,
profiling (2.073 ms) : 2019, 2126
. : milestone, 2073,
tracing (2.058 ms) : 2007, 2110
. : milestone, 2058,
|
What Does This Do
Enables the "optimized" TagMap by default
Motivation
OptimizedTagMap is special HashMap that is designed to be good at common tracer usage patterns.
OptimizedTagMap uses immutable TagMap.Entry-s
By using immutable TagMap.Entry-s...
TagMap.Entry-s are also capable of storing primitives without boxing
All of these capabilities are intended to minimize the allocation done by the tracer when constructing Span-s
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]