Skip to content

add request-id to lambda start/end invocation calls #9991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add request-id to lambda start/end invocation calls #9991

wants to merge 6 commits into from

Conversation

@ojproductions
Copy link
Contributor

@ojproductions ojproductions commented Nov 17, 2025 •
edited
Loading

What Does This Do

tldr: Adds the lambda request ID as a header when making calls to start/end-invocation in lambda datadog extension

  • pulls requestID from awsContext to be added to invocation calls
  • updates signatures in function signatures in coreTracer to include lambdaRequestIds
  • adds propagated lambdaRequestId as headers
  • unit tests

Motivation

APMSVLS-274

Additional Notes

Contributor Checklist

Jira ticket: APMSVLS-274

@datadog-official

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/request-id-header
git_commit_date 1763557084 1763563798
git_commit_sha 5adec51 3241b0f
release_version 1.56.0-SNAPSHOT~5adec51856 1.56.0-SNAPSHOT~3241b0f7c3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763565730 1763565730
ci_job_id 1244770757 1244770757
ci_pipeline_id 83151165 83151165
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-rcvpx198 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-rcvpx198 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097502
Total [baseline] (10.783 s) : 0, 10782706
Agent [candidate] (1.1 s) : 0, 1100024
Total [candidate] (10.773 s) : 0, 10773146
section appsec
Agent [baseline] (1.281 s) : 0, 1281082
Total [baseline] (11.056 s) : 0, 11056059
Agent [candidate] (1.276 s) : 0, 1276202
Total [candidate] (11.016 s) : 0, 11016484
section iast
Agent [baseline] (1.234 s) : 0, 1233736
Total [baseline] (11.198 s) : 0, 11198237
Agent [candidate] (1.234 s) : 0, 1233904
Total [candidate] (11.097 s) : 0, 11097208
section profiling
Agent [baseline] (1.23 s) : 0, 1230335
Total [baseline] (11.057 s) : 0, 11057423
Agent [candidate] (1.228 s) : 0, 1228182
Total [candidate] (11.025 s) : 0, 11025416
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.098 s -
Agent appsec 1.281 s 183.579 ms (16.7%)
Agent iast 1.234 s 136.233 ms (12.4%)
Agent profiling 1.23 s 132.833 ms (12.1%)
Total tracing 10.783 s -
Total appsec 11.056 s 273.354 ms (2.5%)
Total iast 11.198 s 415.531 ms (3.9%)
Total profiling 11.057 s 274.718 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent appsec 1.276 s 176.179 ms (16.0%)
Agent iast 1.234 s 133.88 ms (12.2%)
Agent profiling 1.228 s 128.158 ms (11.7%)
Total tracing 10.773 s -
Total appsec 11.016 s 243.338 ms (2.3%)
Total iast 11.097 s 324.061 ms (3.0%)
Total profiling 11.025 s 252.27 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (704.152 ms) : 0, 704152
BytebuddyAgent [candidate] (705.937 ms) : 0, 705937
GlobalTracer [baseline] (248.424 ms) : 0, 248424
GlobalTracer [candidate] (248.869 ms) : 0, 248869
AppSec [baseline] (32.231 ms) : 0, 32231
AppSec [candidate] (32.274 ms) : 0, 32274
Debugger [baseline] (64.079 ms) : 0, 64079
Debugger [candidate] (64.174 ms) : 0, 64174
Remote Config [baseline] (632.02 µs) : 0, 632
Remote Config [candidate] (645.815 µs) : 0, 646
Telemetry [baseline] (8.084 ms) : 0, 8084
Telemetry [candidate] (8.202 ms) : 0, 8202
Flare Poller [baseline] (3.671 ms) : 0, 3671
Flare Poller [candidate] (3.686 ms) : 0, 3686
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (732.311 ms) : 0, 732311
BytebuddyAgent [candidate] (727.609 ms) : 0, 727609
GlobalTracer [baseline] (240.323 ms) : 0, 240323
GlobalTracer [candidate] (239.608 ms) : 0, 239608
IAST [baseline] (24.805 ms) : 0, 24805
IAST [candidate] (24.636 ms) : 0, 24636
AppSec [baseline] (173.692 ms) : 0, 173692
AppSec [candidate] (174.07 ms) : 0, 174070
Debugger [baseline] (60.616 ms) : 0, 60616
Debugger [candidate] (60.952 ms) : 0, 60952
Remote Config [baseline] (698.579 µs) : 0, 699
Remote Config [candidate] (702.019 µs) : 0, 702
Telemetry [baseline] (8.207 ms) : 0, 8207
Telemetry [candidate] (8.319 ms) : 0, 8319
Flare Poller [baseline] (3.814 ms) : 0, 3814
Flare Poller [candidate] (3.928 ms) : 0, 3928
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (825.811 ms) : 0, 825811
BytebuddyAgent [candidate] (826.786 ms) : 0, 826786
GlobalTracer [baseline] (237.224 ms) : 0, 237224
GlobalTracer [candidate] (237.519 ms) : 0, 237519
IAST [baseline] (27.293 ms) : 0, 27293
IAST [candidate] (31.595 ms) : 0, 31595
AppSec [baseline] (34.035 ms) : 0, 34035
AppSec [candidate] (29.471 ms) : 0, 29471
Debugger [baseline] (61.262 ms) : 0, 61262
Debugger [candidate] (60.588 ms) : 0, 60588
Remote Config [baseline] (542.13 µs) : 0, 542
Remote Config [candidate] (556.764 µs) : 0, 557
Telemetry [baseline] (7.673 ms) : 0, 7673
Telemetry [candidate] (7.585 ms) : 0, 7585
Flare Poller [baseline] (3.525 ms) : 0, 3525
Flare Poller [candidate] (3.489 ms) : 0, 3489
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (731.86 ms) : 0, 731860
BytebuddyAgent [candidate] (730.636 ms) : 0, 730636
GlobalTracer [baseline] (222.294 ms) : 0, 222294
GlobalTracer [candidate] (222.117 ms) : 0, 222117
AppSec [baseline] (32.273 ms) : 0, 32273
AppSec [candidate] (32.159 ms) : 0, 32159
Debugger [baseline] (63.048 ms) : 0, 63048
Debugger [candidate] (62.831 ms) : 0, 62831
Remote Config [baseline] (644.716 µs) : 0, 645
Remote Config [candidate] (647.174 µs) : 0, 647
Telemetry [baseline] (7.892 ms) : 0, 7892
Telemetry [candidate] (7.903 ms) : 0, 7903
Flare Poller [baseline] (3.763 ms) : 0, 3763
Flare Poller [candidate] (3.763 ms) : 0, 3763
ProfilingAgent [baseline] (97.207 ms) : 0, 97207
ProfilingAgent [candidate] (96.992 ms) : 0, 96992
Profiling [baseline] (97.823 ms) : 0, 97823
Profiling [candidate] (97.573 ms) : 0, 97573
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1104176
Total [baseline] (8.871 s) : 0, 8870879
Agent [candidate] (1.106 s) : 0, 1105531
Total [candidate] (8.849 s) : 0, 8848631
section iast
Agent [baseline] (1.232 s) : 0, 1232330
Total [baseline] (9.517 s) : 0, 9516872
Agent [candidate] (1.233 s) : 0, 1233065
Total [candidate] (9.508 s) : 0, 9507732
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.104 s -
Agent iast 1.232 s 128.153 ms (11.6%)
Total tracing 8.871 s -
Total iast 9.517 s 645.993 ms (7.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.106 s -
Agent iast 1.233 s 127.534 ms (11.5%)
Total tracing 8.849 s -
Total iast 9.508 s 659.102 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (708.928 ms) : 0, 708928
BytebuddyAgent [candidate] (710.185 ms) : 0, 710185
GlobalTracer [baseline] (249.806 ms) : 0, 249806
GlobalTracer [candidate] (249.879 ms) : 0, 249879
AppSec [baseline] (32.629 ms) : 0, 32629
AppSec [candidate] (32.65 ms) : 0, 32650
Debugger [baseline] (63.857 ms) : 0, 63857
Debugger [candidate] (63.902 ms) : 0, 63902
Remote Config [baseline] (647.44 µs) : 0, 647
Remote Config [candidate] (641.532 µs) : 0, 642
Telemetry [baseline] (8.166 ms) : 0, 8166
Telemetry [candidate] (8.155 ms) : 0, 8155
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.709 ms) : 0, 3709
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (825.903 ms) : 0, 825903
BytebuddyAgent [candidate] (826.149 ms) : 0, 826149
GlobalTracer [baseline] (237.291 ms) : 0, 237291
GlobalTracer [candidate] (237.648 ms) : 0, 237648
IAST [baseline] (28.278 ms) : 0, 28278
IAST [candidate] (28.867 ms) : 0, 28867
AppSec [baseline] (33.18 ms) : 0, 33180
AppSec [candidate] (32.436 ms) : 0, 32436
Debugger [baseline] (59.78 ms) : 0, 59780
Debugger [candidate] (59.986 ms) : 0, 59986
Remote Config [baseline] (542.273 µs) : 0, 542
Remote Config [candidate] (546.638 µs) : 0, 547
Telemetry [baseline] (7.593 ms) : 0, 7593
Telemetry [candidate] (7.724 ms) : 0, 7724
Flare Poller [baseline] (3.422 ms) : 0, 3422
Flare Poller [candidate] (3.492 ms) : 0, 3492
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/request-id-header
git_commit_date 1763557084 1763563798
git_commit_sha 5adec51 3241b0f
release_version 1.56.0-SNAPSHOT~5adec51856 1.56.0-SNAPSHOT~3241b0f7c3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763566209 1763566209
ci_job_id 1244770758 1244770758
ci_pipeline_id 83151165 83151165
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lxzk1m7n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lxzk1m7n 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+91.326µs; +187.716µs] or [+3.238%; +6.657%]		 worse
[+202.919µs; +718.733µs] or [+2.586%; +9.160%]		 unstable
[-213.724op/s; +72.912op/s] or [-16.502%; +5.630%]		 2.960ms 8.307ms 1224.750op/s 2.820ms 7.847ms 1295.156op/s
scenario:load:petclinic:no_agent:high_load better
[-1.991ms; -0.408ms] or [-10.555%; -2.163%]		 unsure
[-3.286ms; -0.297ms] or [-10.530%; -0.951%]		 unstable
[-9.880op/s; +43.005op/s] or [-4.101%; +17.849%]		 17.660ms 29.419ms 257.500op/s 18.859ms 31.210ms 240.938op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.375 ms) : 19175, 19575
.   : milestone, 19375,
appsec (18.355 ms) : 18169, 18541
.   : milestone, 18355,
code_origins (17.986 ms) : 17806, 18167
.   : milestone, 17986,
iast (17.649 ms) : 17473, 17825
.   : milestone, 17649,
profiling (18.69 ms) : 18504, 18876
.   : milestone, 18690,
tracing (18.548 ms) : 18359, 18737
.   : milestone, 18548,
section candidate
no_agent (18.118 ms) : 17932, 18305
.   : milestone, 18118,
appsec (18.545 ms) : 18357, 18732
.   : milestone, 18545,
code_origins (17.992 ms) : 17813, 18170
.   : milestone, 17992,
iast (17.764 ms) : 17586, 17942
.   : milestone, 17764,
profiling (19.131 ms) : 18936, 19326
.   : milestone, 19131,
tracing (18.002 ms) : 17824, 18181
.   : milestone, 18002,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.375 ms [19.175 ms, 19.575 ms] -
appsec 18.355 ms [18.169 ms, 18.541 ms] -1.02 ms (-5.3%)
code_origins 17.986 ms [17.806 ms, 18.167 ms] -1.389 ms (-7.2%)
iast 17.649 ms [17.473 ms, 17.825 ms] -1.726 ms (-8.9%)
profiling 18.69 ms [18.504 ms, 18.876 ms] -685.249 µs (-3.5%)
tracing 18.548 ms [18.359 ms, 18.737 ms] -827.223 µs (-4.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.118 ms [17.932 ms, 18.305 ms] -
appsec 18.545 ms [18.357 ms, 18.732 ms] 426.335 µs (2.4%)
code_origins 17.992 ms [17.813 ms, 18.17 ms] -126.564 µs (-0.7%)
iast 17.764 ms [17.586 ms, 17.942 ms] -354.202 µs (-2.0%)
profiling 19.131 ms [18.936 ms, 19.326 ms] 1.013 ms (5.6%)
tracing 18.002 ms [17.824 ms, 18.181 ms] -116.006 µs (-0.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.209 ms) : 1197, 1221
.   : milestone, 1209,
iast (3.285 ms) : 3243, 3326
.   : milestone, 3285,
iast_FULL (5.889 ms) : 5830, 5949
.   : milestone, 5889,
iast_GLOBAL (3.539 ms) : 3490, 3588
.   : milestone, 3539,
profiling (2.165 ms) : 2145, 2185
.   : milestone, 2165,
tracing (1.809 ms) : 1794, 1824
.   : milestone, 1809,
section candidate
no_agent (1.211 ms) : 1200, 1222
.   : milestone, 1211,
iast (3.217 ms) : 3172, 3262
.   : milestone, 3217,
iast_FULL (6.029 ms) : 5928, 6131
.   : milestone, 6029,
iast_GLOBAL (3.748 ms) : 3685, 3812
.   : milestone, 3748,
profiling (2.069 ms) : 2051, 2088
.   : milestone, 2069,
tracing (1.785 ms) : 1771, 1799
.   : milestone, 1785,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.209 ms [1.197 ms, 1.221 ms] -
iast 3.285 ms [3.243 ms, 3.326 ms] 2.076 ms (171.7%)
iast_FULL 5.889 ms [5.83 ms, 5.949 ms] 4.68 ms (387.2%)
iast_GLOBAL 3.539 ms [3.49 ms, 3.588 ms] 2.33 ms (192.8%)
profiling 2.165 ms [2.145 ms, 2.185 ms] 956.335 µs (79.1%)
tracing 1.809 ms [1.794 ms, 1.824 ms] 600.016 µs (49.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.211 ms [1.2 ms, 1.222 ms] -
iast 3.217 ms [3.172 ms, 3.262 ms] 2.006 ms (165.7%)
iast_FULL 6.029 ms [5.928 ms, 6.131 ms] 4.818 ms (397.9%)
iast_GLOBAL 3.748 ms [3.685 ms, 3.812 ms] 2.537 ms (209.5%)
profiling 2.069 ms [2.051 ms, 2.088 ms] 858.465 µs (70.9%)
tracing 1.785 ms [1.771 ms, 1.799 ms] 574.203 µs (47.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/request-id-header
git_commit_date 1763557084 1763563798
git_commit_sha 5adec51 3241b0f
release_version 1.56.0-SNAPSHOT~5adec51856 1.56.0-SNAPSHOT~3241b0f7c3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1763566000 1763566000
ci_job_id 1244770761 1244770761
ci_pipeline_id 83151165 83151165
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-gl5orku5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-gl5orku5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.403ms; -1.061ms] or [-37.717%; -28.520%]		 2.489ms 3.721ms
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.485 ms) : 1474, 1497
.   : milestone, 1485,
appsec (3.721 ms) : 3502, 3940
.   : milestone, 3721,
iast (2.226 ms) : 2161, 2290
.   : milestone, 2226,
iast_GLOBAL (2.271 ms) : 2206, 2336
.   : milestone, 2271,
profiling (2.072 ms) : 2020, 2124
.   : milestone, 2072,
tracing (2.05 ms) : 2000, 2101
.   : milestone, 2050,
section candidate
no_agent (1.49 ms) : 1479, 1502
.   : milestone, 1490,
appsec (2.489 ms) : 2437, 2541
.   : milestone, 2489,
iast (2.224 ms) : 2159, 2288
.   : milestone, 2224,
iast_GLOBAL (2.275 ms) : 2210, 2340
.   : milestone, 2275,
profiling (2.075 ms) : 2023, 2127
.   : milestone, 2075,
tracing (2.046 ms) : 1995, 2096
.   : milestone, 2046,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.474 ms, 1.497 ms] -
appsec 3.721 ms [3.502 ms, 3.94 ms] 2.236 ms (150.5%)
iast 2.226 ms [2.161 ms, 2.29 ms] 740.647 µs (49.9%)
iast_GLOBAL 2.271 ms [2.206 ms, 2.336 ms] 785.424 µs (52.9%)
profiling 2.072 ms [2.02 ms, 2.124 ms] 586.64 µs (39.5%)
tracing 2.05 ms [2.0 ms, 2.101 ms] 565.117 µs (38.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.49 ms [1.479 ms, 1.502 ms] -
appsec 2.489 ms [2.437 ms, 2.541 ms] 998.357 µs (67.0%)
iast 2.224 ms [2.159 ms, 2.288 ms] 733.248 µs (49.2%)
iast_GLOBAL 2.275 ms [2.21 ms, 2.34 ms] 784.682 µs (52.6%)
profiling 2.075 ms [2.023 ms, 2.127 ms] 584.481 µs (39.2%)
tracing 2.046 ms [1.995 ms, 2.096 ms] 555.103 µs (37.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3241b0f7c3, baseline=1.56.0-SNAPSHOT~5adec51856
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.945 s) : 14945000, 14945000
.   : milestone, 14945000,
appsec (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
iast (18.537 s) : 18537000, 18537000
.   : milestone, 18537000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
.   : milestone, 17885000,
profiling (14.749 s) : 14749000, 14749000
.   : milestone, 14749000,
tracing (14.879 s) : 14879000, 14879000
.   : milestone, 14879000,
section candidate
no_agent (15.583 s) : 15583000, 15583000
.   : milestone, 15583000,
appsec (15.349 s) : 15349000, 15349000
.   : milestone, 15349000,
iast (18.568 s) : 18568000, 18568000
.   : milestone, 18568000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
.   : milestone, 17937000,
profiling (15.167 s) : 15167000, 15167000
.   : milestone, 15167000,
tracing (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.945 s [14.945 s, 14.945 s] -
appsec 14.966 s [14.966 s, 14.966 s] 21.0 ms (0.1%)
iast 18.537 s [18.537 s, 18.537 s] 3.592 s (24.0%)
iast_GLOBAL 17.885 s [17.885 s, 17.885 s] 2.94 s (19.7%)
profiling 14.749 s [14.749 s, 14.749 s] -196.0 ms (-1.3%)
tracing 14.879 s [14.879 s, 14.879 s] -66.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.583 s [15.583 s, 15.583 s] -
appsec 15.349 s [15.349 s, 15.349 s] -234.0 ms (-1.5%)
iast 18.568 s [18.568 s, 18.568 s] 2.985 s (19.2%)
iast_GLOBAL 17.937 s [17.937 s, 17.937 s] 2.354 s (15.1%)
profiling 15.167 s [15.167 s, 15.167 s] -416.0 ms (-2.7%)
tracing 14.907 s [14.907 s, 14.907 s] -676.0 ms (-4.3%)

@ojproductions ojproductions added type: enhancement Enhancements and improvements comp: core Tracer core labels Nov 18, 2025
@ojproductions
Copy link
Contributor Author

ojproductions commented Nov 18, 2025

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 18, 2025

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ojproductions ojproductions marked this pull request as ready for review November 18, 2025 19:41
@ojproductions ojproductions requested review from a team as code owners November 18, 2025 19:41
@ojproductions ojproductions requested review from mcculls and removed request for a team November 18, 2025 19:41
mcculls
mcculls reviewed Nov 19, 2025
View reviewed changes
dd-trace-core/src/main/java/datadog/trace/lambda/LambdaHandler.java Outdated
RequestBody body =
RequestBody.create(
jsonMediaType,
writeValueAsString(event)); // MAYBE remove CoreTracer parameter since it is not used
Copy link
Contributor

@mcculls mcculls Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no plan to use it in the near future then I would remove the CoreTracer parameter now

mhlidd
mhlidd approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@mhlidd mhlidd mhlidd approved these changes

Assignees

@mhlidd mhlidd

Labels

comp: core Tracer core type: enhancement Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ojproductions @mcculls @mhlidd