Unwinding fix - remove heuristic around infinite loop detection #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heuristic was triggering in the wrong cases (recursive functions).
r1viollet
commented
Dec 4, 2025
| } | ||
| #ifdef DEBUG | ||
| // We often fallback to frame pointer unwinding (which logs an error) | ||
| int const dwfl_error_value = dwfl_errno(); |
Collaborator
Author
There was a problem hiding this comment.
I have a minor doubt on how useful it is to read the errno value.
Collaborator
Author
|
CI was amazing! It shows our exit conditions are terrible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Heuristic was triggering in the wrong cases (recursive functions).
Motivation
Fix call stacks on some arm test cases.
Additional Notes
NA
How to test the change?
The bad-boggle-solver is a good test for this.