Skip to content

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jul 25, 2025

What does this PR do?

Add Proxmox recommended monitors

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt changed the title Add Proxmox recommended monitors [AI-5348] Add Proxmox recommended monitors Jul 25, 2025
@sarah-witt sarah-witt added assets/no-deploy Prevents APW from deploying this PR in staging and removed assets/no-deploy Prevents APW from deploying this PR in staging labels Jul 25, 2025
"created_at": "2025-07-25",
"last_updated_at": "2025-07-25",
"title": "Memory Usage High on Proxmox Node",
"description": "Notify your team when the Memory usage is too high on a Proxmox Node.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarah-witt can you add more information to the Description, see the developer docs for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@steveny91
Copy link
Contributor

steveny91 commented Jul 29, 2025

I forget, the host tag in this case is the actual proxmox node and not the host running the check right? Looks good to me if so.

steveny91
steveny91 previously approved these changes Jul 29, 2025
"name": "Memory Usage High on Proxmox VM {{host.host}} on Node {{host.proxmox_node}}",
"type": "query alert",
"query": "avg(last_5m):avg:proxmox.mem.used{proxmox_type:vm} by {host} / avg:proxmox.mem.total{proxmox_type:vm} by {host} * 100 > 90",
"message": "{{#is_alert}}\\VM {{host.host}} on Node {{host.proxmox_node}} is reporting high memory usage (at or above 90%).\\n{{/is_alert}}\\n\\n{{#is_warning}}\\VM {{host.host}} on Node {{host.proxmox_node}} is reporting higher memory usage (at or above 80%).\\n{{/is_warning}}\\n\\n{{#is_recovery}}\\\\Memory usage for VM {{host.host}} on Node {{host.proxmox_node}} is back to normal.\\n{{/is_recovery}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does host.proxmox_node work here? I could be misremembering, but I think this only works if you do a aggregation by proxmox_node tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does work! maybe because it's a host tag:
Screenshot 2025-07-29 at 3 10 45 PM

but i noticed some formatting issues with the message (and host.host doesn't work) so i'll push a fix for that. thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that's good to know.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review July 29, 2025 19:21

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • proxmox/assets/monitors/node_cpu_usage.json
    • proxmox/assets/monitors/node_memory_usage.json
    • proxmox/assets/monitors/vm_cpu_usage.json
    • proxmox/assets/monitors/vm_memory_usage.json
steveny91
steveny91 previously approved these changes Jul 29, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review July 29, 2025 20:51

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • proxmox/assets/monitors/node_memory_usage.json
@sarah-witt sarah-witt added this pull request to the merge queue Jul 30, 2025
Merged via the queue into master with commit 09b73fa Jul 30, 2025
38 checks passed
@sarah-witt sarah-witt deleted the sarah/proxmox-monitors branch July 30, 2025 15:15
justin-lesko pushed a commit that referenced this pull request Aug 4, 2025
* add vm cpu usage

* node monitor

* Add memory usage

* fix dates and paths

* fix date

* update descriptions

* spacing

* fix spacing and host.name

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants