-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(json-specs): improve descriptions and examples #20878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
9bd7631
to
7168651
Compare
## extra_metrics: | ||
## - <METRIC_1> | ||
## - <METRIC_2> | ||
## ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking, but just noticed that these don't line up.
## ``` | |
## ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker, but noticed that the backticks aren't aligned for this field:
## ```
## extra_metrics:
## - <METRIC_1>
## - <METRIC_2>
## ```
7168651
to
b8c45c2
Compare
What does this PR do?
Fix minor issues in spec files:
custom_queries
auth_type
metrics
(openmetrics)extra_metrics
(openmetrics)share_labels
(openmetrics)custom_queries
(elastic)metrics
(openmetrics)share_labels
(openmetrics)custom_queries
(elastic)expected_mode
(zk)Impact of the changes on the integration configuration UI:
Motivation
https://datadoghq.atlassian.net/browse/FA-1028
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged