Fix accidental removal of getMetrics function #250
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tests re-exporting of functions etc.
Overall package sizeSelf size: 1.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-12-17 09:53:55 Comparing candidate commit 7477554 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 29 unstable metrics. scenario:profiler-heavy-load-no-wall-profiler-18
|
nsavoire
approved these changes
Dec 17, 2025
szegedi
added a commit
that referenced
this pull request
Dec 17, 2025
* Fix accidental removal of getMetrics function * Import time profiler through top-level profiler file, ensuring that it tests re-exporting of functions etc.
Merged
szegedi
added a commit
that referenced
this pull request
Dec 17, 2025
* Fix accidental removal of getMetrics function * Import time profiler through top-level profiler file, ensuring that it tests re-exporting of functions etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds
getMetricsback to the profiler API.Motivation:
I somehow managed to accidentally delete re-exporting of the function from
index.tsin #247; this needs to be fixed.Additional Notes:
Ironically, this is the same thing that was missing in 5.11.0 and got fixed with #237, prompting 5.11.1. History repeated itself.
How to test the change?:
This previously managed to slip past the tests because a relevant test was directly importing
time-profiler.ts, which exportsgetMetrics. However, the top-levelindex.tsneeds to re-export the API, and since the test didn't import through the top-level, this didn't get caught. I now modified the test to import through the top-levelindex.ts.