[python] Add asyncio check #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KowalskiThomas
force-pushed
the
kowalski/python-add-asyncio-check
branch
2 times, most recently
from
3a647b0 to
6d15dfd
Compare
KowalskiThomas
force-pushed
the
kowalski/python-add-asyncio-check
branch
from
6d15dfd to
a3ac50c
Compare
r1viollet
reviewed
Nov 25, 2025
|
|
||
| EXECUTION_TIME_SEC = float(os.environ.get("EXECUTION_TIME_SEC", "2")) | ||
|
|
||
| short_task = asyncio.create_task(my_coroutine(EXECUTION_TIME_SEC / 2)) |
Collaborator
There was a problem hiding this comment.
💭 a sleep after this could make sure that you do not instrument it while it is not scheduled.
Contributor
Author
There was a problem hiding this comment.
As discussed offline, the Task is already pretty much scheduled ("scheduled soon") after this call
r1viollet
reviewed
Nov 25, 2025
r1viollet
previously approved these changes
Nov 25, 2025
Collaborator
r1viollet
left a comment
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
Thanks for adding this in. Just a minor idea.
KowalskiThomas
force-pushed
the
kowalski/python-add-asyncio-check
branch
from
a3ac50c to
e29236e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new (very basic) correctness check for
asynciostacks.Note that, for now, we focus on a basic use case, and we don't even get fully correct stacks as we don't have visibility into the
asyncio.sleepcall (not included in the expected regular expression).This has been fixed in dd-trace-py but has not been released yet.