perf: Optimize AnimatedList rendering with useCallback #745
+216
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every time AnimatedList re-renders (e.g., when selectedIndex changes), new inline functions are created for onMouseEnter and onClick for each list item. This causes all AnimatedItem children to re-render unnecessarily, which can impact performance, especially with longer lists.
Solution
Refactored the event handlers to use React’s useCallback hook. This memoizes the functions, ensuring their references remain stable across renders. As a result, only the AnimatedItem that is actually affected will re-render.
Key Changes
Imported useCallback from React.
Wrapped handleItemMouseEnter, handleItemClick, and handleScroll in useCallback.
Updated the items.map() loop to call these memoized handlers.
Verification
This is a pure performance optimization. All existing functionality (mouse hover, click, keyboard navigation, scroll gradients) should work exactly as before with no breaking changes.