Add styling for QScrollBar/QComboBox controls for the Steam Deck theme #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added examples of using QResources and generating the stylesheet through |
loathingKernel
force-pushed
the
qss-fixes
branch
from
5665113 to
5704848
Compare
loathingKernel
force-pushed
the
qss-fixes
branch
from
5704848 to
6d647cb
Compare
loathingKernel
force-pushed
the
qss-fixes
branch
from
848b08e to
4a849ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds theming for QScrollBar/QComboBox controls for the Steam Deck theme
Preview:
The icon file paths are injected in to the CSS string dynamically right now. I would like to move them into a QResources file but I wanted to get the ok from you before going forward with that. The QResources as far as the theme is concerned should include the QSS file along with any images it uses. The icons are modified from Font Awesome icons and I should check up on their exact license.
Generally I consider this WIP that should take some time due to availability. Feel free to comment with any concerns in the meantime though.
Edit: Regarding the license, it should be ok to use. These icons are take from the FontAwesome repository, they are
caret-downandcaret-up