Skip to content

Add null check for engagement in permission validation #13832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentijnscholten merged 1 commit into from
Dec 8, 2025
+3 −1
Merged

Add null check for engagement in permission validation #13832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dojo/authorization/authorization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ def user_has_permission(user, obj, permission):
isinstance(obj, Risk_Acceptance)
and permission == Permissions.Risk_Acceptance
):
return user_has_permission(user, obj.engagement.product, permission)
if obj.engagement is not None:
return user_has_permission(user, obj.engagement.product, permission)
return user_has_global_permission(user, permission)
if ((
isinstance(obj, Finding | Stub_Finding)
) and permission in Permissions.get_finding_permissions()) or (
Expand Down
Loading