fix: bug with aerodrome-v1 staked supply ratio #2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
there's a possible error with Aerodrome V1's rewards APY calculation. the
stakedSupplyRatiois actually inverted becausetotalSupplyis the gauges supply of LP tokens andpoolSupplyis the aerodrome pool.this could be an issue because if half of the LPs have staked, it actually doubles the yield. the discrepancy is less obvious as more LPs stake, but there is a visible overestimation of the APY for the newer pools. and since there's no point of being an unstaked LP, the bug disappears very quickly as the ratio nears 1.