-
Notifications
You must be signed in to change notification settings - Fork 1k
Aura adaptor changes #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aura adaptor changes #2166
Conversation
|
@slasher125 Apologies, missed your comments. Just re-pushed the PR with the same changes, and now the pool IDs will be the same as previously. It's possible that some other data (underlying tokens, pool symbol) have changed - do I need to ensure that these are identical too? |
|
@0xRichter ideally we dont make big changes to symbols, do u have an example of what changed there? btw can u confirm the adapter runs fine for you locally, i'm getting empty array |
|
Ah, sorry, didn't test my changes. Probably a bad rebase. I'm not sure what changed exactly, but the data was very broken before and in an incorrect format (including the recommended approach for the pool IDs), so I tried to make all of the data correct. But I can go back through and more closely match the initial data. Will ping you when it's sorted. Thanks for your help! |
e66ae46 to
a27be22
Compare
|
The aura adapter exports pools: |
|
@slasher125 Looks good now |
✅ NEW PR MAINTAINS THE OLD POOL INDEXES ✅
This change rewrites the currently broken Aura adaptor. The existing implementation does not show accurate APRs, misses many pools, and does not support a number of chains.
The new implementation utilises the Balancer and Aura subgraphs, as well as on-chain data in order to provide accurate APRs for the pools through implementing the in-app APR calculations within the adaptor.