Skip to content

fix: prevent Invalid URL error in prepareBaseUrl for http/https baseUrl #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: prevent Invalid URL error in prepareBaseUrl for http/https baseUrl #8434

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23c8efc
fix: correct prepareBaseUrl handling for web URLs (fixes #8364)
yasinkocak Aug 19, 2025
6b30788
Merge branch 'master' into master
yasinkocak Aug 28, 2025
5de3c2a
Merge branch 'master' into master
yasinkocak Sep 18, 2025
06ca605
Merge branch 'master' into master
yasinkocak Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/api/test-page-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,18 @@ export function getUrl (url: string, base?: URL): string {
}

export function prepareBaseUrl (url: string): URL {
url = join(url, '/');
return isAbsolute(url) ? pathToFileURL(url) : new URL(url);
// If it's a web URL (http/https), use it directly
if (/^https?:\/\//i.test(url)) {
return new URL(url.endsWith('/') ? url : url + '/');
}

// Handle file URLs explicitly
if (/^file:\/\//i.test(url)) {
return new URL(url);
}

// Otherwise, treat it as filesystem path
return pathToFileURL(isAbsolute(url) ? url : join(process.cwd(), url));
}

export function assertPageUrl (url: string, callsiteName: string): void {
Expand Down