feat: Add comprehensive message validation with configurable Laravel-style validation rules #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…style validation rules - Add message validation configuration to textify.php config - Implement validation for required, min, and max message length - Use Laravel-style validation naming (required, min, max) for consistency - Add validateMessageContent() method to BaseProvider - Enhanced error handling in all Bangladeshi SMS providers - Add comprehensive MessageValidationTest suite - Support for nullable messages when required=false - Proper whitespace handling and error messages - All tests passing with PHPStan validation Fixes issue with ReveSMS error 114 'Content not provided' and similar validation issues across all providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces message content validation for SMS messages, ensuring that messages meet configurable requirements before being sent. The validation logic is configurable via the
textify.phpconfig file and is enforced in all providers. Comprehensive tests are included to verify the validation behavior for various scenarios.Message Validation Feature:
validationsection toconfig/textify.phpto configure message requirements, including whether messages are required, minimum length, and maximum length.validateMessageContentmethod inBaseProvider.phpto enforce these validation rules before sending a message. If validation fails, an error response is returned. [1] [2]Testing and Coverage:
MessageValidationTest.phpto cover all key validation scenarios: required/nullable messages, minimum/maximum length, valid messages, and whitespace-only messages.Minor Codebase Cleanup:
BulkSmsBdProvider.php.