Skip to content

Conversation

mingyuan-xia
Copy link

No description provided.

on-behalf-of: @appetizerio <contact@appetizer.io>
Signed-off-by: Mingyuan Xia <ken@appetizer.io>
@mingyuan-xia
Copy link
Author

can we have a merge and a new release?

@koral--
Copy link
Member

koral-- commented Feb 17, 2021

Could you fix merge conflicts?

@UrielCh
Copy link

UrielCh commented Apr 5, 2022

Added to @u4/adbkit 3.1.7

@koral--
Copy link
Member

koral-- commented Apr 6, 2022

@pcrepieux @denis99999 WDYT should we switch to external dependency in case of adbkit?

@denis99999
Copy link

@pcrepieux @denis99999 WDYT should we switch to external dependency in case of adbkit?

My personal opinion is to keep internal dependencies, for now...

@pcrepieux
Copy link

@pcrepieux @denis99999 WDYT should we switch to external dependency in case of adbkit?

I am afraid this raises a few more questions ;-)

  • how to ensure the external dependency doesn't and also will not break stf ? (the conservative choice of using own's adbkit at least provides some sort of stability but maybe at the cost of a lack of evolution)
  • @UrielCh's adbkit seems to do more things than just adb which I guess was the initial intent of adbkit. Wouldn't it overlap some other features that are in stf ?
  • However his version of adbkit seems to be more active. So, another question I have : why not contributing here ? (just wondering, I have no bias at all)

So basically, for now I'd stay with the initial version, but am open to carefully consider other options depending on the feedbacks I'll get.

@UrielCh
Copy link

UrielCh commented Apr 6, 2022

Hi pcrepieux
can you send me an E-mail, in English or in French ?

and... yes my adbkit do much more than the original one, I have already built my own STF platform, in typescript + VueJS 3, currently working using STF service, but will sooner work with Genymobile/scrcpy:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants