feat(ffi): expose RDCleanPath #1014

irvingoujAtDevolution · 2025-10-07T21:16:37Z

Add RDCleanPath support for Devolutions.IronRDP .NET package

github-actions · 2025-10-07T21:22:17Z

Coverage Report 🤖 ⚙️

Past:
Total lines: 30171
Covered lines: 18762 (62.19%)

New:
Total lines: 30171
Covered lines: 18763 (62.19%)

Diff: +0.00%

[this comment will be updated automatically]

Copilot

Pull Request Overview

This PR integrates Devolutions.IronRDP with Gateway by adding RDCleanPath protocol support and KDC proxy capabilities for .NET. The implementation enables RDP connections through Devolutions Gateway using WebSocket transport with optional Kerberos authentication via KDC proxy.

Adds RDCleanPath protocol FFI bindings for gateway communication
Implements KDC proxy support for Kerberos authentication through the gateway
Provides WebSocket transport layer and gateway connection methods for .NET

Reviewed Changes

Copilot reviewed 14 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ffi/src/rdcleanpath.rs	Adds FFI bindings for RDCleanPath protocol operations
ffi/src/lib.rs	Registers new rdcleanpath module
ffi/src/error.rs	Adds error handling for RDCleanPath and DER operations
ffi/src/credssp/mod.rs	Extends KerberosConfig with KDC proxy support
ffi/dotnet/Devolutions.IronRdp/src/WebsocketStream.cs	Implements WebSocket stream adapter for network transport
ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs	Provides gateway connection methods using RDCleanPath
ffi/dotnet/Devolutions.IronRdp/src/Framed.cs	Adds custom PDU hint interface for flexible frame detection
ffi/dotnet/Devolutions.IronRdp/src/Connection.cs	Updates connection logic to support HTTP/HTTPS requests for KDC proxy
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Program.cs	Updates example to remove unused parameter
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/TokenGenerator.cs	Adds JWT token generation client for gateway authentication
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs	Integrates gateway connection support in example application
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Devolutions.IronRdp.ConnectExample.csproj	Updates ImageSharp package version
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/Devolutions.IronRdp.AvaloniaExample.csproj	Updates Avalonia package versions
ffi/Cargo.toml	Adds ironrdp-rdcleanpath dependency

Comments suppressed due to low confidence (1)

ffi/dotnet/Devolutions.IronRdp/src/Connection.cs:129

[nitpick] Use conventional null comparison style 'decoded == null' instead of Yoda condition 'null == decoded' for better readability and consistency with C# conventions.

            if (null == decoded)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ffi/src/rdcleanpath.rs

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

ffi/src/rdcleanpath.rs

ffi/src/error.rs

CBenoit · 2025-10-08T08:37:03Z

Please, open a separate PR for the KDC proxy part.

ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

Copilot

Pull Request Overview

Copilot reviewed 17 out of 39 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ffi/src/rdcleanpath.rs

irvingoujAtDevolution · 2025-10-08T18:49:35Z

ffi/src/clipboard/mod.rs

-        if let Err(err) = self.sender.send(message) {
-            error!("Failed to send clipboard message: {:?}", err);
+        if let Err(error) = self.sender.send(message) {
+            error!(?error, "Failed to send clipboard message");


Just fixing styles along the way, let me know if you mind

irvingoujAtDevolution · 2025-10-08T18:49:51Z

ffi/src/connector/mod.rs

        }

        pub fn with_dynamic_channel_display_control(&mut self) -> Result<(), Box<IronRdpError>> {
            self.with_dvc(DisplayControlClient::new(|c| {


Just fixing styles along the way, let me know if you mind

irvingoujAtDevolution · 2025-10-08T19:32:39Z

Ready for review @CBenoit

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

ffi/dotnet/Devolutions.IronRdp/src/RDCleanPathConnection.cs

CBenoit · 2025-10-17T00:24:04Z

ffi/dotnet/Devolutions.IronRdp/src/RDCleanPathConnection.cs

+        // Step 2: Get client local address (dummy for WebSocket)
+        string clientAddr = "127.0.0.1:33899";


note: I guess this is fine? But that’s not what we do in the Rust native client. Look for the connect_ws function.

CBenoit · 2025-10-17T00:44:56Z

ffi/src/error.rs

+pub struct GenericError(pub anyhow::Error);
+
+impl Display for GenericError {
+    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+        write!(f, "{:#}", self.0)
+    }
+}
+
+impl From<GenericError> for IronRdpErrorKind {
+    fn from(_val: GenericError) -> Self {
+        IronRdpErrorKind::Generic
+    }
+}


note: This can be made less verbose to write, and the IronRdpErrorKind type can be removed. Will be a follow up from me.

Ok, thanks!

CBenoit · 2025-10-17T00:46:45Z

ffi/src/rdcleanpath.rs

+        }
+
+        /// Converts the PDU into a typed enum for pattern matching
+        pub fn into_enum(&self) -> Result<Box<RDCleanPathResult>, Box<IronRdpError>> {


naming: In the FFI, we do not return an enum. Actually, I don’t think you need a whole different type, it’s not useful here since we can’t manipulate field by field, and there is no destructuring pattern matching.

ffi/src/rdcleanpath.rs

- Add RDCleanPath FFI bindings - Implement WebSocket stream for gateway connections - Add GatewayConnection API with CredSSP hostname extraction - Support both direct and gateway connection modes

Add KerberosConfig FFI bindings and HTTP/HTTPS network protocol handling for KDC proxy authentication via Devolutions Gateway. - Expose KerberosConfig::new() in FFI layer - Add GenerateKdcToken() method to TokenGenerator - Update GatewayConnection to accept KDC proxy parameters - Implement HTTP/HTTPS request handling in ResolveGenerator - Auto-generate client hostname for Kerberos authentication 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CBenoit · 2025-10-23T14:47:26Z

ffi/src/rdcleanpath.rs

+            let rdcleanpath = self
+                .0
+                .clone()
+                .into_enum()


issue: You don’t need to use into_enum() at all. You can access the properties directly.

CBenoit

Perform a last self-review (also double check comments not yet resolved), especially fix the last comment, and then feel free to merge yourself

irvingoujAtDevolution requested a review from CBenoit October 7, 2025 21:17

CBenoit requested a review from Copilot October 8, 2025 08:21

Copilot AI reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Show resolved Hide resolved

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/src/error.rs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

irvingoujAtDevolution changed the title ~~feat(ffi): intergrate Devolutions.IronRDP with Gateway~~ feat(ffi): integrate Devolutions.IronRDP with Gateway Oct 8, 2025

irvingoujAtDevolution changed the title ~~feat(ffi): integrate Devolutions.IronRDP with Gateway~~ feat(ffi): integrate Devolutions.IronRDP with RDCleanPath Oct 8, 2025

irvingoujAtDevolution requested a review from Copilot October 8, 2025 17:11

Copilot AI reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Outdated Show resolved Hide resolved

irvingoujAtDevolution requested a review from CBenoit October 8, 2025 18:39

irvingoujAtDevolution commented Oct 8, 2025

View reviewed changes

CBenoit reviewed Oct 16, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 16, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Show resolved Hide resolved

CBenoit reviewed Oct 17, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp/src/RDCleanPathConnection.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 17, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Outdated Show resolved Hide resolved

irvingoujAtDevolution and others added 6 commits October 22, 2025 11:50

feat(ffi): add RDCleanPath gateway support for .NET

1a1fe35

- Add RDCleanPath FFI bindings - Implement WebSocket stream for gateway connections - Add GatewayConnection API with CredSSP hostname extraction - Support both direct and gateway connection modes

clean up

db87b15

clean up

02b96eb

Apply suggestion from @Copilot

6d71d91

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

e93746b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

irvingoujAtDevolution and others added 12 commits October 22, 2025 11:50

fix

dbe7d46

clean

ab87e25

review fix

1da7a29

review fix

f14efa9

review fix

83dc989

Update ffi/src/rdcleanpath.rs

2366696

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

strip off kdc proxy

2536134

remove proxy

ee7347e

undo changes

cfd1d05

clean up

107ad4f

clean up

fb6313d

clean up

7771c3c

irvingoujAtDevolution force-pushed the gateway-with-ffi branch from c54e496 to 7771c3c Compare October 22, 2025 15:51

irvingoujAtDevolution added 5 commits October 22, 2025 12:49

review fix

ca5a6ab

review fix

93628d4

review fix

9a1ff9f

review fix

b693a48

CI fix

a19b1c7

CBenoit reviewed Oct 23, 2025

View reviewed changes

CBenoit changed the title ~~feat(ffi): integrate Devolutions.IronRDP with RDCleanPath~~ feat(ffi): expose RDCleanPath Oct 23, 2025

CBenoit approved these changes Oct 23, 2025

View reviewed changes

fixing CI

9640a3e

irvingoujAtDevolution enabled auto-merge (squash) October 29, 2025 20:34

fixing CI

efb62a9

irvingoujAtDevolution merged commit d3e0cb1 into master Oct 30, 2025
10 checks passed

irvingoujAtDevolution deleted the gateway-with-ffi branch October 30, 2025 16:38

		// Step 2: Get client local address (dummy for WebSocket)
		string clientAddr = "127.0.0.1:33899";

feat(ffi): expose RDCleanPath #1014

feat(ffi): expose RDCleanPath #1014

Uh oh!

Conversation

irvingoujAtDevolution commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 🤖 ⚙️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CBenoit commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

irvingoujAtDevolution Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

irvingoujAtDevolution Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

irvingoujAtDevolution commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CBenoit Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

irvingoujAtDevolution Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CBenoit Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

irvingoujAtDevolution commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

CBenoit commented Oct 8, 2025 •

edited

Loading

CBenoit Oct 17, 2025 •

edited

Loading

CBenoit left a comment •

edited

Loading