-
Notifications
You must be signed in to change notification settings - Fork 7
fix: container now copies managed python into runtime #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test error will be fixed by #296 |
I have tested this against All is working great and I can deploy the runtime container to the cluster like so: HOWEVER: the debug container fails to start in cluster with:
Which is because this line in the runtime is not applied to the debug target:
|
I believe we just need to add this to the build stage:
trying it in fastcs-example. |
Adding the Path in the debug phase does fix the issue. It also repeats the same line but I figure that is required as the two stages have differing base images. |
Another question. I have put sdtio-socket in fastcs-example dependencies and set the args as below:
This gives us ability to connect to the console from a shell in the container. The dependency could go in the copier template and be available to all. Do we want that? |
I have seen a non-critical problem which is that when you use the debug container and you are not root you don't get all the nice .inputrc etc. because you can't read the /root folder. I've been changing the HOME variable to /tmp so ipython has a place to write its files. I thought that was why I was not seeing the friendly shell but it turns out I cant see it even with HOME=/root. It would be nice to have a solution that gives writable dot files and nice bash config. The simplest answer is to make the /root folder writeable by all at build time. I feel that is mildly dangerous though. Maybe the best way to handle this is to not support fancy bashrc in cluster. You have |
It looks like the README is out of date, still mentioning pip et al. I have not checked the docs yet. |
I think this is probably too specific to go in the copier template, best to leave it in the FastCS modules |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
We could make it writable to all just for the debug container? That should be reasonably safe... |
Fixes #294