-
Notifications
You must be signed in to change notification settings - Fork 144
build: drop python 3.9 support #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
||
(If you need python 3.8 or 3.9 support, please use `disnake<2.12`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(If you need python 3.8 or 3.9 support, please use `disnake<2.12`) |
I don't really want to recommend this, there's a reason these versions are eol (or, in the case of 3.9, will soon be eol)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. But 2.7 support stayed around on a lot of readmes too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah :/ Still, recommending unmaintained versions (of both disnake and Python itself) doesn't feel right. If anyone insists on using 3.8/3.9 nonetheless, they should do so at their own risk, imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on pushing the ecosystem away from supporting EOL software. It should be possible for those who really really need to do it and know why. 2.7 was (and even still is!!) a mess to migrate away. I wouldn't want to keep propagating that throughout the ecosystem.
Adding it into the README makes it seem like you are supporting the decision to use EOL versions, as if this project is one whose use case overlaps with a massive user base who can't upgrade.
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: arielle <me@arielle.codes>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: arielle <me@arielle.codes>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: arielle <me@arielle.codes>
1eb3461
to
94c6528
Compare
No description provided.