fix: a few bugs/security concerns #3360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afety - Introduced a Zod schema for validating Docker container IDs in the docker router. - Updated WebSocket server to validate container IDs and shell types before execution. - Improved shell command safety by escaping container IDs and shell types in various services. - Added log path validation to prevent path traversal vulnerabilities in deployment and mount services.
LukeHagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR is addressing a few places in the code base that seemingly could use a bit more validation given the context and the way that commands are templated out to run on the host machine.
There are a few places where command injection could be possible, and a few other places where some possible bugs were found in things like JSON parsing, or unexpected sleep behavior.
Checklist
Before submitting this PR, please make sure that:
canarybranch.