ci: remove all existing advisories before generating #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I've opened #153 to have the generator script do the removing, but it might make sense to still land this change as it should ensure we're definitely not retaining old advisories, in case the script messes up for some reason 🤔 |
G-Rath
force-pushed
the
ci/remove-advisories-before-generating
branch
from
8002c53 to
6c3e7a5
Compare
Unifex
approved these changes
Dec 9, 2025
Collaborator
Unifex
left a comment
Unifex
left a comment
There was a problem hiding this comment.
I think the scorched earth approach makes sense.
LGTM
G-Rath
force-pushed
the
ci/remove-advisories-before-generating
branch
from
6c3e7a5 to
762d569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help ensure that advisories that are no longer being generated are not retained in the database, which isn't handled by our scripts since this situation should only ever happen when we've made a change to our scripts to fix a bug