DYN-8303: Enable deferred node load #16361

zeusongit · 2025-07-09T19:15:37Z

Purpose

This PR:

Adds deferred node load for graphs above 150 node count.
Simplifies node styles
Adds node cached images as resx resources.
Node progress counter

Profile results (time denotes when the workspace becomes available)

512

OLD	NEW
11.41s	4.73s
10.59s	7.2s
9.89s	5.2s

Manekin

OLD	NEW
85s	50.5s
82s	48.9s
83s	47.2s

Declarations

Check these if you believe they are true

Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Adds deferred node load for graphs above 150 node count.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

@achintyabhat

# Conflicts: # src/DynamoCoreWpf/Views/Core/NodeView.xaml # src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

…eNodeBackground

…8303-2

Introduced a new middleware to handle user authentication for protected routes. This ensures that only authenticated users can access certain endpoints, improving application security.

…8303-2

Replaces the static node loading indicator with an animated progress spinner and detailed loading status in NotificationsControl.xaml. Makes LoadedNodesCount and NodesLoading properties public in WorkspaceViewModel for better data binding. Caches node images after conversion in NodeView.xaml.cs to improve performance.

DYN-8303: Static Field Optimizations

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8303

Copilot

Pull Request Overview

This PR enables deferred loading of node visuals for large graphs, simplifies node styling, and integrates cached node images as embedded resources.

Implements deferred node rendering above a node-count threshold with a progress counter
Refactors zoom fade styles into shared bindings and cleans up animated styles
Adds embedded resource support for node images and wiring in the workspace view model

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
NodeView.xaml.cs	Introduces deferred UI loading, bitmap-based port markers, new style bindings, and resource-based node images
WorkspaceViewModel.cs	Tracks loaded node count, exposes `NodesLoading`, and logs load times
PublicAPI.Unshipped.txt	Exposes new `LoadedNodesCount`, `NodesLoading`, and `GetNodeImage` APIs
DynamoCoreWpf.csproj	Embeds `NodeCacheImages.resx` as a resource
NotificationsControl.xaml	Displays node-loading progress spinner and counter

Comments suppressed due to low confidence (3)

src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs:198

[nitpick] Private fields are typically prefixed with _ (e.g. _nodeLoadStopwatch) to distinguish them from properties. Consider renaming for consistency.

        private Stopwatch nodeLoadStopwatch = new Stopwatch();

src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs:605

The new NodesLoading property and related deferred-load behavior appear untested. Consider adding unit or integration tests to verify the loading indicator and count logic.

        public bool NodesLoading

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:1453

Ensure that the embedded resource name matches the manifest path of NodeCacheImages.resx. A mismatch here can cause a null stream and silent failures.

                        var stream = assembly.GetManifestResourceStream("Dynamo.Wpf.NodeCacheImages.resources");

Copilot · 2025-07-09T19:18:10Z

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

@@ -423,7 +440,7 @@ public NodeView()
                Background = Brushes.Transparent,
            };

-            Canvas.SetZIndex(renameIndicator, 5);
+            SetValue(Panel.ZIndexProperty, 5);


Calling SetValue here applies ZIndex to the NodeView itself rather than to renameIndicator. You should use renameIndicator.SetValue(Panel.ZIndexProperty, 5); to target the correct element.

Suggested change

SetValue(Panel.ZIndexProperty, 5);

renameIndicator.SetValue(Panel.ZIndexProperty, 5);

Copilot · 2025-07-09T19:18:11Z

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

+                    var writeableBitmap = new WriteableBitmap(bitmap);
+
+                    // Define rectangle position and size
+                    int width = 5, height = 29;


[nitpick] These magic numbers (5, 29) are not self-documenting. Consider extracting them into named constants or adding a comment explaining their origin.

Copilot · 2025-07-09T19:18:11Z

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

+        private static readonly Dictionary<string, BitmapImage> _cachedImages =
+        new Dictionary<string, BitmapImage>(StringComparer.OrdinalIgnoreCase);
+
+        //Freeze the static resource to reduce memory overhead... Not sure we need this. 


[nitpick] This TODO-style comment is ambiguous. Either clarify whether freezing is still required or remove it to keep the codebase clean.

Suggested change

//Freeze the static resource to reduce memory overhead... Not sure we need this.

// Freeze the static resources to reduce memory overhead and improve performance.

Copilot · 2025-07-09T19:18:11Z

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

+                return result;
+
+            // Define the specific invalid characters to remove
+            char[] invalidChars = { '/', '\\', ':', '*', '?', '"', '<', '>', '|' };


[nitpick] Consider using Path.GetInvalidFileNameChars() instead of hard-coding invalid filename characters to keep this list in sync with the underlying OS.

Copilot · 2025-07-09T19:18:11Z

src/DynamoCoreWpf/Controls/NotificationsControl.xaml

+            <StackPanel
+                Orientation="Horizontal" Margin="5,0"
+                VerticalAlignment="Center">
+                <Image Name="downloadingIcon"


[nitpick] Use x:Name instead of Name in XAML to ensure uniqueness across templates and avoid potential conflicts.

Copilot · 2025-07-09T19:18:12Z

src/DynamoCoreWpf/Controls/NotificationsControl.xaml

+            <StackPanel
+                Orientation="Horizontal" Margin="5,0"
+                VerticalAlignment="Center">
+                <Image Name="downloadingIcon"


The progress spinner lacks an automation name or tooltip for screen readers. Consider adding AutomationProperties.Name="Loading nodes" or similar.

Copilot · 2025-07-09T19:18:12Z

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

+                    }
+
+                    // Write transparent pixels to the left 5px of the image
+                    writeableBitmap.WritePixels(


[nitpick] Calling WritePixels in a loop for each port marker may cause UI thread stalls on large graphs. Evaluate batching or offloading to a background thread to improve responsiveness.

Replaces the hardcoded list of invalid filename characters with System.IO.Path.GetInvalidFileNameChars() when sanitizing node names. Also removes obsolete API entries related to node image retrieval from the public API file.

avidit · 2025-07-30T13:15:41Z

@cursor review

cursor · 2025-07-30T13:15:44Z

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

saintentropy and others added 30 commits May 4, 2025 19:57

FirstPass

25dae72

Progress update

5a87ccd

Add Inport triggers and tooltip

106b8ed

Progress Update

fa31803

Progress on NodeView

6724c68

Simplify InPorts including lazy load of level spinner

13b986d

Cleanup + Support Code blocks

7ce45f0

Simplify Ports and verify with Groups

e940553

Add NodeAutoCompleteHover to InPort

1d71b38

Finish node ui

6c6cdd8

fix typo

f87bcf2

Merge branch 'master' into CodeOnlyNodeView

24a854d

# Conflicts: # src/DynamoCoreWpf/Views/Core/NodeView.xaml # src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs

NodeView clean up, comments, and deregister event handlers

3d96a27

Inport cleanup, comments, and deregister events

3f79235

remove BeginInit / EndInit

e74e8d8

Clean up Outport, add comments, deregister events

b387f0d

Fix test and realing names with old names

3037ffc

Update api docs

98a6a11

Fix tests

3136e36

Fix API doc

c84d3e4

fIx api doc

3bb8e4b

First pass at lazy load

0ccf319

Change to background

10ca6ea

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into Cach…

c6fecdc

…eNodeBackground

add missing trigger

5fc3ed3

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into DYN-…

7833644

…8303-2

Update NodeView.xaml.cs

4ae3ee7

reinstate opacity converter

9d09c73

Apply defer based on node count

dded96f

record node load time in debug

ef6af98

zeusongit and others added 13 commits July 1, 2025 23:05

Add user authentication middleware

6a6da15

Introduced a new middleware to handle user authentication for protected routes. This ensures that only authenticated users can access certain endpoints, improving application security.

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into DYN-…

d96130f

…8303-2

deferred load

d6a4ac9

Update NodeView.xaml.cs

955df68

comments

d1fc40f

remove customized nodes

a02d7ef

Move the ResourceSet to static field

400b8a4

Removed commented out sections

973a34d

typo

1691e06

typo

9dc24fb

Merge pull request #2 from saintentropy/DYN-8303-2

3e651d5

DYN-8303: Static Field Optimizations

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into 8303-t

ce53697

zeusongit requested review from saintentropy, a team and Copilot July 9, 2025 19:15

github-actions bot reviewed Jul 9, 2025

View reviewed changes

zeusongit mentioned this pull request Jul 9, 2025

DYN-8303: Enable deferred node load #16337

Closed

8 tasks

Copilot AI reviewed Jul 9, 2025

View reviewed changes

zeusongit added 3 commits July 9, 2025 16:55

Update NodeView.xaml.cs

4de0299

remove stopwatch

9ee2bdd

Use Path.GetInvalidFileNameChars for node name sanitization

d7a7511

Replaces the hardcoded list of invalid filename characters with System.IO.Path.GetInvalidFileNameChars() when sanitizing node names. Also removes obsolete API entries related to node image retrieval from the public API file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DYN-8303: Enable deferred node load #16361

DYN-8303: Enable deferred node load #16361

zeusongit commented Jul 9, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

Copilot AI Jul 9, 2025

Uh oh!

avidit commented Jul 30, 2025

Uh oh!

cursor bot commented Jul 30, 2025

Uh oh!

Uh oh!

	SetValue(Panel.ZIndexProperty, 5);
	renameIndicator.SetValue(Panel.ZIndexProperty, 5);

	//Freeze the static resource to reduce memory overhead... Not sure we need this.
	// Freeze the static resources to reduce memory overhead and improve performance.

DYN-8303: Enable deferred node load #16361

Are you sure you want to change the base?

DYN-8303: Enable deferred node load #16361

Conversation

zeusongit commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

avidit commented Jul 30, 2025

Uh oh!

cursor bot commented Jul 30, 2025

Uh oh!

Uh oh!

zeusongit commented Jul 9, 2025 •

edited

Loading