Corrects negative silicate values in sea ice #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in V1.5.0. Silicate limitation should not be wrapped in an if statement for iron tracers. nonBFB with active BGC. BFB for all else.
16 tasks
eclare108213
approved these changes
Apr 3, 2025
Collaborator
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
This bug has also been tested and fixed in CICE-Consortium#519.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in Icepack V1.5.0.
Silicate limitation should not be wrapped in an if statement for iron tracers.
nonBFB with active BGC. BFB for all else.
See Issue E3SM-Project/E3SM#7127
Tested in a fully-coupled biogeochemistry simulation. Simulation page and comparisons with a control run are here:
https://acme-climate.atlassian.net/wiki/spaces/HESF/pages/5121212417/20250314.v3.LR.CBGC.FrazilEcosys.noSpinup.pm-cpu
The ice.log files with Icepack v1.5.0 with active BGC has warning messages after about 4 years indicating negative silicate. This is because silicate limitation is not implemented correctly. The fix removes an incorrect if block around the silicate limitation functions. With this fix, no warning messages were observed over the simulation (~36 years).