Skip to content

Conversation

@mattldawson
Copy link
Collaborator

@mattldawson mattldawson commented Sep 2, 2025

Updates the GitHub actions to include the proper dependencies.

The tests still fail, but because of existing memory issues in the tests:

2025-09-02T23:47:11.9147772Z 86% tests passed, 8 tests failed out of 58
2025-09-02T23:47:11.9148313Z 
2025-09-02T23:47:11.9148478Z Total Test time (real) = 656.46 sec
2025-09-02T23:47:11.9148816Z 
2025-09-02T23:47:11.9148962Z The following tests FAILED:
2025-09-02T23:47:11.9149359Z 	 20 - memcheck_growclr (Failed)
2025-09-02T23:47:11.9149779Z 	 22 - memcheck_growin (Failed)
2025-09-02T23:47:11.9150483Z 	 24 - memcheck_growsub (Failed)
2025-09-02T23:47:11.9150925Z 	 26 - memcheck_grow (Failed)
2025-09-02T23:47:11.9151398Z 	 30 - memcheck_kappawetr (Failed)
2025-09-02T23:47:11.9151714Z 	 34 - memcheck_nuc2 (Failed)
2025-09-02T23:47:11.9151993Z 	 36 - memcheck_nuc (Failed)
2025-09-02T23:47:11.9152453Z 	 38 - memcheck_pheat (Failed)
2025-09-02T23:47:11.9152858Z Errors while running CTest
2025-09-02T23:47:11.9181975Z ##[error]Process completed with exit code 8.

A separate issue will be created to look into these.

Copilot AI review requested due to automatic review settings September 2, 2025 21:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions Ubuntu workflow to install necessary system dependencies before building the project. The change adds a new step to install cmake, gfortran, and various NetCDF and LAPACK libraries that are required for the build process.

  • Adds dependency installation step with apt-get commands
  • Installs build tools (cmake, gfortran) and scientific computing libraries (NetCDF, LAPACK, BLAS)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fvitt fvitt merged commit 62ae0b7 into ESCOMP:main Sep 3, 2025
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants