Skip to content

[Feature] Tuist 적용 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Monfi98 merged 8 commits into from
Jul 16, 2025
Merged

[Feature] Tuist 적용 #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2acedde
[#133] Tuist 적용
Monfi98 Jul 13, 2025
142b56e
[#133] Dependencies Package.swift로 이동
Monfi98 Jul 15, 2025
968ecd3
[#133] 필요없는 참조 제거
Monfi98 Jul 15, 2025
a959806
[#133] infoPlist 분리
Monfi98 Jul 16, 2025
9262334
[#133] gitignore 추가
Monfi98 Jul 16, 2025
e7f1667
[#133] 파일 제거
Monfi98 Jul 16, 2025
641259f
[#133] .package.resolved 제거
Monfi98 Jul 16, 2025
6f17cd4
[#133] git ignore 수정
Monfi98 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,13 @@ fastlane/test_output

iOSInjectionProject/
RunLog/Secrets.xcconfig

# Tuist
Derived
*.idea
*.xcodeproj
*.xcworkspace
*.package.resolved
*.xcuserstate
*.xcuserdatad
*.xcscmblueprint
41 changes: 41 additions & 0 deletions RunLog/Project.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import ProjectDescription

let project = Project(
name: "RunLog",
organizationName: "ESTSOFTiOSTEAM1",
targets: [
.target(
name: "RunLog",
destinations: [.iPhone],
product: .app,
bundleId: "com.ESTSOFTiOSTEAM1.IEEE.RunLog",
deploymentTargets: .iOS("17.0"),
infoPlist: .file(path: "RunLog/InfoPlists/RunLog-info.plist"),
sources: ["RunLog/Sources/**"],
resources: ["RunLog/Resources/**"],
dependencies: [
Comment on lines +11 to +16
Copy link

@coderabbitai coderabbitai bot Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Info.plist 경로 불일치로 빌드 실패 위험

infoPlist: .file(path: "RunLog/InfoPlists/RunLog-info.plist") 경로가 실제로 커밋된 RunLog/RunLog/InfoPlists/RunLog-Info.plist 와(과) 폴더/대소문자 모두 달라 Xcode & Tuist가 파일을 찾지 못합니다.

-      infoPlist: .file(path: "RunLog/InfoPlists/RunLog-info.plist"),
+      infoPlist: .file(path: "RunLog/RunLog/InfoPlists/RunLog-Info.plist"),

동일 이슈가 테스트 타깃에도 있습니다(아래 diff 참고).

-      infoPlist: .file(path: "RpTest/InfoPlists/RpTest-info.plist"),
+      infoPlist: .file(path: "RunLog/RpTest/InfoPlists/RpTest-Info.plist"),

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In RunLog/Project.swift around lines 11 to 16, the infoPlist file path is
incorrect and causes build failures because it does not match the actual
committed path and casing. Update the infoPlist path from
"RunLog/InfoPlists/RunLog-info.plist" to the correct
"RunLog/RunLog/InfoPlists/RunLog-Info.plist" to match the real file location and
casing. Also, apply the same fix to the test target's infoPlist path if it has
the same issue.

Copy link
Contributor Author

@Monfi98 Monfi98 Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

루트는 여기가 맞아.

Copy link

@coderabbitai coderabbitai bot Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@Monfi98 파일 구조를 확인해보겠습니다.

🏁 Script executed:

#!/bin/bash
# Project.swift 파일 위치 확인
echo "=== Project.swift 파일 위치 ==="
find . -name "Project.swift" -type f

echo -e "\n=== 실제 Info.plist 파일들 위치 ==="
find . -name "*Info.plist" -type f -o -name "*info.plist" -type f

echo -e "\n=== RunLog 프로젝트 구조 ==="
ls -la RunLog/

echo -e "\n=== InfoPlists 디렉토리 구조 ==="
find . -type d -name "*InfoPlists*"
find . -type d -name "*Infoplists*"

echo -e "\n=== RunLog/InfoPlists 경로 확인 ==="
if [ -d "RunLog/InfoPlists" ]; then
    echo "RunLog/InfoPlists 디렉토리 존재"
    ls -la RunLog/InfoPlists/
else
    echo "RunLog/InfoPlists 디렉토리 없음"
fi

echo -e "\n=== RpTest/InfoPlists 경로 확인 ==="
if [ -d "RpTest/InfoPlists" ]; then
    echo "RpTest/InfoPlists 디렉토리 존재"
    ls -la RpTest/InfoPlists/
else
    echo "RpTest/InfoPlists 디렉토리 없음"
fi

Length of output: 1463

@Monfi98 맞습니다! 루트 경로 구조는 정확합니다.

파일 구조 확인 결과:

  • Project.swift는 RunLog/ 디렉토리에 위치
  • 상대 경로 "RunLog/InfoPlists/RunLog-info.plist"는 올바르게 RunLog/RunLog/InfoPlists/를 참조

다만 대소문자 차이만 있습니다:

  • 참조: RunLog-info.plist (소문자 i)
  • 실제 파일: RunLog-Info.plist (대문자 I)

동일한 이슈가 테스트 타깃에도 있습니다:

  • 참조: RpTest-info.plist
  • 실제 파일: RpTest-Info.plist

경로 구조에 대한 지적은 잘못되었습니다. 대소문자만 수정하면 됩니다.

✏️ Learnings added 
Learnt from: Monfi98
PR: ESTSOFT-iOS-01/RunLog#134
File: RunLog/Project.swift:11-16
Timestamp: 2025-07-16T08:01:39.547Z
Learning: RunLog 프로젝트에서 Project.swift 파일은 RunLog/ 디렉토리 안에 위치하며, 상대 경로 참조 시 "RunLog/InfoPlists/..."는 "RunLog/RunLog/InfoPlists/..."를 의미하는 올바른 구조입니다.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

.external(name: "SnapKit"),
.external(name: "Then"),
.external(name: "Moya"),
.external(name: "CombineMoya"),
.external(name: "NVActivityIndicatorView"),
.external(name: "NVActivityIndicatorViewExtended"),
],
coreDataModels: [
.coreDataModel("RunLog/Sources/Data/DTO/DTOs.xcdatamodeld")
]
),
.target(
name: "RpTest",
destinations: [.iPhone],
product: .unitTests,
bundleId: "com.ESTSOFTiOSTEAM1.IEEE.RpTest",
deploymentTargets: .iOS("17.0"),
infoPlist: .file(path: "RpTest/InfoPlists/RpTest-info.plist"),
sources: ["RpTest/Sources/**"],
dependencies: [
.target(name: "RunLog")
]
)
]
)
22 changes: 22 additions & 0 deletions RunLog/RpTest/InfoPlists/RpTest-Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
<string>$(DEVELOPMENT_LANGUAGE)</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
</plist>
0 RunLog/RpTest/DayLogUseCaseTest.swift → ...og/RpTest/Sources/DayLogUseCaseTest.swift
View file
Open in desktop
File renamed without changes.
0 RunLog/RpTest/DoubleTest.swift → RunLog/RpTest/Sources/DoubleTest.swift
View file
Open in desktop
File renamed without changes.
0 RunLog/RpTest/MediaUseCaseTests.swift → ...og/RpTest/Sources/MediaUseCaseTests.swift
View file
Open in desktop
File renamed without changes.
0 RunLog/RpTest/RpTest.swift → RunLog/RpTest/Sources/RpTest.swift
View file
Open in desktop
File renamed without changes.
0 RunLog/RpTest/TestCoreDataContainer.swift → ...pTest/Sources/TestCoreDataContainer.swift
View file
Open in desktop
File renamed without changes.
Loading
Loading