Skip to content

Conversation

thisisandrew
Copy link

@thisisandrew thisisandrew commented Nov 26, 2020

Remove di for Message preference, update TransportBuilder to handle attachment, update SenderBuilder to use TransportBuilder

Module latest 12.10 allows PHP7.3 but dev dependencies for testing require <7.3 so no test for this PR. Fix the dev dependencies in the latest version and we can have tests here.

…ttachment, update SenderBuilder to use TransportBuilder
@lingwooc
Copy link

In magento 2.3.6 The sales_send_order_invoice_emails cron job throws an exception with this PR.

Run SalesInvoiceSendEmailsCron::execute 
                                                                                  
  Cron-job "sales_send_order_invoice_emails" threw exception ReflectionException                                                                               

In ClassReader.php line 26:
                                                                           
  Class Eadesigndev\Pdfgenerator\Model\Email\SenderBuilder does not exist  

Which is true, because this patch replaces it with a TransportBuilder instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants