Fix TransactionListTop default swap asset logic #5222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Aug 27, 2024
| const isPriorityAssetMatch = | ||
| currencyWallet.currencyInfo.pluginId === priorityAsset.pluginId && | ||
| currencyWallet.enabledTokenIds.some(enabledTokenId => enabledTokenId === priorityAsset.tokenId) | ||
| (priorityAsset.tokenId == null || currencyWallet.enabledTokenIds.some(enabledTokenId => enabledTokenId === priorityAsset.tokenId)) |
There was a problem hiding this comment.
Instead of Array.some, try Array.includes on the right-Rand side. Much simpler.
Jon-edge
force-pushed
the
jon/fix/default-swap-assets
branch
from
95904e9 to
9d8bc2c
Compare
Mainnet assets were not properly being accounted for
Jon-edge
force-pushed
the
jon/fix/default-swap-assets
branch
from
9d8bc2c to
d560731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainnet assets were not properly being accounted for
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: