Sam/cardano-staking #5223
Sam/cardano-staking #5223
Conversation
samholmes
force-pushed
the
sam/cardano-staking
branch
2 times, most recently
from
22019ee to
7172c9c
Compare
| return clean.data | ||
| const raw = await fetchKiln(`/v1/eth/onchain/v2/stakes?wallets=${address}`) | ||
| const response = asKilnResponse(asStakesResponse)(raw) | ||
| if ('message' in response) throw new Error('Kiln error: ' + response.message) |
There was a problem hiding this comment.
This is never true after the cleaner, did you mean to look in raw?
| const filteredOps = clean.data.filter((op): op is ExitOperation => op != null) | ||
| const raw = await fetchKiln(`/v1/eth/onchain/v2/operations?wallets=${address}`) | ||
| const response = asKilnResponse(asOperations)(raw) | ||
| if ('message' in response) throw new Error('Kiln error: ' + response.message) |
There was a problem hiding this comment.
This is never true after the cleaner, did you mean to look in raw?
|
|
||
| export type AdaStakeTransaction = ReturnType<typeof asAdaStakeTransaction> | ||
| const asAdaStakeTransaction = asObject({ | ||
| unsigned_tx_hash: asString, |
There was a problem hiding this comment.
unsigned_tx_hash and a handful of keys in asAdaStake aren't used, can they be commented out?
| adapterConfig: { | ||
| exitQueueAddress: '0x8979117a69DfA7F4D4E3c7B59197ff03f4A2CeAF', | ||
| type: 'ethereum-pooled-kiln', | ||
| accountId: ENV.KILN_TESTNET_ACCOUNT_ID, |
There was a problem hiding this comment.
I don't understand why this was added. It seems like implementation details for ADA staking are becoming unnecessary implementation details for ETH.
There was a problem hiding this comment.
It's because it's a requirement for the shared KilnApi lib. Shall I make it optional, then I'd need to add assertions to each KilnApi method that requires it... I could do that if you think that's better. Or perhaps this lends to the question whether KilnApi should be broken up into two separate APIs. Or perhaps I can make the accountId a parameter for each method. Which seems best?
There was a problem hiding this comment.
It's only used in adaStakeTransaction just pass it in there
| CNIOWindows: 3047f2d8165848a3936a0a755fee27c6b5ee479b | ||
| disklet: e7ed3e673ccad9d175a1675f9f3589ffbf69a5fd | ||
| DoubleConversion: 76ab83afb40bddeeee456813d9c04f67f78771b5 | ||
| DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 |
| FirebaseMessaging: 585984d0a1df120617eb10b44cad8968b859815e | ||
| fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9 | ||
| glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2 | ||
| glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b |
src/plugins/stake-plugins/types.ts
Outdated
|
|
||
| // Do not allow Max button when staking | ||
| disableMaxStake?: boolean | ||
| mustMaxStake?: boolean |
samholmes
force-pushed
the
sam/cardano-staking
branch
2 times, most recently
from
5dfb018 to
3ca06ab
Compare
samholmes
force-pushed
the
sam/cardano-staking
branch
from
3ca06ab to
4bac450
Compare
samholmes
force-pushed
the
sam/cardano-staking
branch
from
4bac450 to
c5e1cf4
Compare
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: