Skip to content

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Sep 5, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up to you if the seemingly unnecessary KilnError or not. Otherwise it's approved.

The purpose of this is to have an error message that we know we can
safely show to the user because we know it's human readable and
translated.
@samholmes samholmes enabled auto-merge September 5, 2024 23:48
@samholmes samholmes merged commit 836b2f2 into develop Sep 5, 2024
2 checks passed
@samholmes samholmes deleted the sam/kiln-ada-fix2 branch September 5, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants