Fix display bug caused by flipping inputs on SwapCreateScene #5240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/fix-swap-swapity-swap
branch
from
ed4dab9 to
b56c50e
Compare
peachbits
requested changes
Sep 10, 2024
| control, so there had to ba a reason, but there is not reason given. | ||
| Who ever knows why and is reading this comment, please replace this comment | ||
| with the reason for the console log. | ||
| */ |
There was a problem hiding this comment.
It's probably a debugging turd the reviewer missed. Just delete it, bro.
samholmes
force-pushed
the
sam/fix-swap-swapity-swap
branch
from
b56c50e to
6a9b694
Compare
Because we're flipping the wallets and the amounts for each SwapInput component and each strategy to change this state is mixed between imperative and declarative, we converge with incorrect state. This is because the imperative change to the amounts happens to the SwapInput before it's wallet state is change (which is the declarative state change). Ultimately the mix of two techniques on state management is the cause of the bug. The solution is to add a delay to the imperative change, to allow for the component's state to be updated before making the imperative changes.
samholmes
force-pushed
the
sam/fix-swap-swapity-swap
branch
from
6a9b694 to
3bf9a89
Compare
peachbits
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: