Skip to content

Disable autoselect on android #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −1
Open

Disable autoselect on android #5467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased (develop)

- added: "Update Available" modal
- fixed: Reverse text input due to autoselect text on focus on Android.

## 4.23.0 (staging)

Expand Down
3 changes: 2 additions & 1 deletion src/components/themed/FilledTextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export const FilledTextInput = React.forwardRef<FilledTextInputRef, FilledTextIn
autoComplete,
autoCorrect,
autoFocus = false,
autoSelect = false,
autoSelect: autoSelectProp = false,
blurOnClear = false,
blurOnSubmit,
disabled = false,
Expand All @@ -182,6 +182,7 @@ export const FilledTextInput = React.forwardRef<FilledTextInputRef, FilledTextIn
const LeftIcon = iconComponent
const hasIcon = LeftIcon != null
const hasValue = value !== ''
const autoSelect = Platform.OS === 'android' ? false : autoSelectProp

const marginRemStyle = useMarginRemStyle(marginRemProps)

Expand Down
Loading