Skip to content

feat: allow shader crate cargo features to be passed through spirv-builder #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow shader crate cargo features to be passed through spirv-builder #1124

wants to merge 1 commit into from

Conversation

schell
Copy link

@schell schell commented Jan 31, 2024

  • Adds fields for default-features and features to SpirvBuilder
  • Pipes those fields through to the cargo command that builds the shader crate

@schell schell marked this pull request as ready for review February 1, 2024 08:08
@schell schell requested a review from eddyb as a code owner February 1, 2024 08:08
@Firestar99 Firestar99 mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schell