Fix footer buttons text color #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Old: New: |
Contributor
Author
|
The text of the bottoms was blue because of a style that affected the |
This partially reverts commit 2eaabd6. It keeps english translation.
matiboux
reviewed
Sep 8, 2025
Member
matiboux
left a comment
matiboux
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
The translation is appreciated, though the proposed fix was more complex than necessary.
I reverted your changes to "simplify css" because:
- Our current approach is to keep HTML and CSS separate.
- Fixes should address issues by modifying the minimum number of lines.
- Hard-coding a remediation is not optimal, and a simpler solution was available.
The applied fix was to exclude buttons from the link color styling rules.
matiboux
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a pr some minutes ago I noticed that the text of the bottoms were not that visible,
so I decided to commit this pr.
Changes