-
Notifications
You must be signed in to change notification settings - Fork 531
[WinUI] Calcite integration #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a suggestion to keep the changes a lot smaller, and the samples easier to copy
<Setter Property="FontFamily" Value="/Resources/Fonts/calcite-ui-icons-24.ttf#calcite-ui-icons-24" /> | ||
<Setter Property="FontSize" Value="25" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative you could have used the calcite font here, and used the content property in the buttons.
So this one would way <Setter Property="FontFamily" Value="{StaticResource CalciteUIIconsMediumFontFamily}" />
And for setting the content property use for instance Content="{StaticResource CalciteUIIcons_Glyph_AnnotateTool}"
You can find the full list here: https://github.com/Esri/calcite-dotnet-toolkit/blob/main/GeneratedResources/WinUI/Icons/Glyphs.xaml
Also the font size is best at 24 for this font.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks! That just solved a bigger issue with the Maui calcite branch that I've been running into
9f458e5
to
1e124f6
Compare
1e124f6
to
954e6a2
Compare
…ome buttons in the settings
…lying from XamlControlsResources
Description
Added the calcite package to the WinUI sample viewer. Minimal changes were necessary, but full functionality depends on at least one fix in the toolkit.
Known Issues
Color Overrides
Type of change
Platforms tested on
Checklist