Skip to content

Conversation

imalcolm1
Copy link
Collaborator

@imalcolm1 imalcolm1 commented Oct 3, 2025

Description

Added the calcite package to the WinUI sample viewer. Minimal changes were necessary, but full functionality depends on at least one fix in the toolkit.

Known Issues

Color Overrides

  • The commit overriding the default calcite brand colors (blue) with the sample brand colors (purple) will not function until the new toolkit version is released

Type of change

  • Sample viewer enhancement

Platforms tested on

  • WinUI

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@imalcolm1 imalcolm1 self-assigned this Oct 3, 2025
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a suggestion to keep the changes a lot smaller, and the samples easier to copy

Comment on lines -9 to -10
<Setter Property="FontFamily" Value="/Resources/Fonts/calcite-ui-icons-24.ttf#calcite-ui-icons-24" />
<Setter Property="FontSize" Value="25" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative you could have used the calcite font here, and used the content property in the buttons.

So this one would way <Setter Property="FontFamily" Value="{StaticResource CalciteUIIconsMediumFontFamily}" />

And for setting the content property use for instance Content="{StaticResource CalciteUIIcons_Glyph_AnnotateTool}"

You can find the full list here: https://github.com/Esri/calcite-dotnet-toolkit/blob/main/GeneratedResources/WinUI/Icons/Glyphs.xaml

Also the font size is best at 24 for this font.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! That just solved a bigger issue with the Maui calcite branch that I've been running into

@imalcolm1 imalcolm1 force-pushed the ian/winui-calcite-integration branch from 9f458e5 to 1e124f6 Compare October 9, 2025 22:28
@imalcolm1 imalcolm1 force-pushed the ian/winui-calcite-integration branch from 1e124f6 to 954e6a2 Compare October 9, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants