Skip to content

Conversation

@chriswebb09
Copy link
Collaborator

Description

This fixes an issue in the sample by restricting the movement to the city limits.

Linked Issue(s)

  • swift/issues/7560

@chriswebb09 chriswebb09 changed the base branch from main to v.next November 19, 2025 14:21
@chriswebb09 chriswebb09 self-assigned this Nov 19, 2025
@chriswebb09 chriswebb09 requested review from a team, CalebRas and zkline101 and removed request for a team November 19, 2025 18:08
@chriswebb09 chriswebb09 marked this pull request as ready for review November 19, 2025 18:30
@CalebRas
Copy link
Collaborator

I am still seeing an error in Find closest facility to multiple points with your branch. Did you maybe fix the wrong sample?

@chriswebb09
Copy link
Collaborator Author

@CalebRas sorry about that, it should work correctly now.

@des12437 des12437 self-requested a review November 24, 2025 18:54
chriswebb09 and others added 2 commits November 24, 2025 13:28
…osestFacilityToMultiplePointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@chriswebb09 chriswebb09 requested review from des12437 and removed request for CalebRas November 24, 2025 21:29
…osestFacilityToMultiplePointsView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@chriswebb09 chriswebb09 requested a review from des12437 November 24, 2025 22:02
des12437
des12437 previously approved these changes Nov 24, 2025
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chriswebb09
Copy link
Collaborator Author

@zkline101 When you get a chance, can you take a look?

@zkline101
Copy link
Contributor

You bet

zkline101
zkline101 previously approved these changes Nov 25, 2025
…osestFacilityToMultiplePointsView.swift

Co-authored-by: Zachary Kline <zkline@esri.com>
@chriswebb09 chriswebb09 dismissed stale reviews from zkline101 and des12437 via 094b19f November 25, 2025 17:49
@chriswebb09 chriswebb09 merged commit 2696436 into v.next Nov 25, 2025
1 check passed
@chriswebb09 chriswebb09 deleted the chriswebb/closest-facility-fix branch November 25, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants