GradientComponent: Fix blending not being enabled #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJtheRedstoner
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call was accidentally dropped in f9c95e8#diff-bc7125e63fa8e1fe130c0591fecb4078dad770ace6f613ec4ce3cb9729c8ee98L126, breaking translucent GradientComponents on versions prior to 1.21.5 unless blending happens to already be enabled.
UIText always enables blending but does not disable it (MC's font renderer itself only disables it on more modern versions, not sure where the cut-off is but 1.12.2 still leaves it enabled), and one of out two remaining GradientComponent we use in Essential (we've mostly switched to GradientEffect) is on top of text, hence why this wasn't noticed immediately.
Linear: EM-3177