Window: Fix incorrect logic in dragging code #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These `if`s used to be early returns and were improperly inverted in c199a84. This is why our integration tests were no longer able to dismiss notifications by dragging them off-screen, because the tests were moving the mouse perfectly horizontally, so no drag event was ever emitted.
Johni0702
requested review from
CallumBugajski,
RedEpicness,
Traben-0 and
Waterdude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
ifs used to be early returns and were improperly inverted in c199a84.This is why our integration tests were no longer able to dismiss notifications by dragging them off-screen, because the tests were moving the mouse perfectly horizontally, so no drag event was ever emitted.