Use BlendState.ALPHA across all components #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traben-0
reviewed
Jun 11, 2025
|
lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new
ElementaVersions:V9switches all components to consistently useURenderPipelineon all Minecraft versions (so we don't have to implementV10for the legacy code paths)V10switches all components to useBlendState.ALPHAinstead ofBlendState.NORMAL, which fixes the alpha channel of the render result, required for proper compositing with MC's new gui renderer in 1.21.6Made these separate versions to aid in debugging if your gui is broken by them, so you can apply them separately to figure out which one your gui doesn't handle properly.