fix: Use URenderPipeline for ColorPicker #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Closing in favor of #92 which copies my color picker changes from Essential and thereby additionally significantly reduces the amount of quads drawn and fixes incorrect rendering at some resolutions due to incorrect rounding in the original code. |
Johni0702
reviewed
Jul 14, 2025
Comment on lines
+277
to
280
| // NO-OP on 1.21.5+ | ||
| UGraphics.enableBlend() | ||
| UGraphics.disableAlpha() | ||
| UGraphics.tryBlendFuncSeparate(770, 771, 1, 0) |
Contributor
There was a problem hiding this comment.
FYI URenderPipeline overrides blend and alpha states on all versions.
Johni0702
reviewed
Jul 14, 2025
| } | ||
|
|
||
| private val pipeline = URenderPipeline.builderWithDefaultShader("vigilance:color_picker", UGraphics.DrawMode.QUADS, UGraphics.CommonVertexFormats.POSITION_COLOR).apply { | ||
| blendState = BlendState.ALPHA.copy(dstAlpha = BlendState.Param.ZERO) |
Contributor
There was a problem hiding this comment.
FYI the blend function used by the original code is just plain wrong. Setting dstAlpha to 0 doesn't make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses URenderPipeline along with UBufferBuilder for ColorPicker