GH-1192 Extend /back functionality to per-death and per-teleport #1192

Jakubk15 · 2025-10-04T16:45:56Z

Described in #1133

Resolves #1133

gemini-code-assist

Code Review

This pull request extends the /back command to differentiate between death and teleport locations, which is a great feature enhancement. The implementation is mostly solid, but I've found a critical issue in the configuration migration that could lead to data loss for users. Additionally, there are several opportunities for refactoring to reduce code duplication and improve readability, particularly in BackCommand and BackService. I've also noted a design consideration regarding a shared configuration setting that could be improved.

...eternalcode/core/configuration/migrations/Migration_0010_Move_back_to_dedicated_section.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackCommand.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

…ion/migrations/Migration_0010_Move_back_to_dedicated_section.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackCommand.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

Rollczi

TeleportService ma stare metody jeszcze

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

igoyek

Follow the instructions of others and it will look good :)

vLuckyyy

The code would become much simpler if you stopped using Pairs. They are not required.

...eternalcode/core/configuration/migrations/Migration_0010_Move_back_to_dedicated_section.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

Jakubk15 · 2025-10-09T08:25:27Z

@vLuckyyy you would have two caches then and the only "simplification" is that you put stuff into a separate cache rather than a Pair

P1otrulla · 2025-10-09T09:51:12Z

@vLuckyyy you would have two caches then and the only "simplification" is that you put stuff into a separate cache rather than a Pair

Imo better create object for it, simple and easy access.
I showed it at the meeting.

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/messages/BackMessages.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackCommand.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/messages/BackMessages.java

...e-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TeleportRequestConfig.java

CitralFlo

is that ok? or github says sth weird?

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

...e-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TeleportRequestConfig.java

...eternalcode/core/configuration/migrations/Migration_0030_Move_back_to_dedicated_section.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackCommand.java

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java

...e-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TeleportRequestConfig.java

Jakubk15 · 2025-10-23T08:49:43Z

is that ok? or github says sth weird?

Will inspect

Rollczi · 2025-10-26T21:45:31Z

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackCommand.java

+        Optional<Position> deathLocation = this.backService.getDeathLocation(target.getUniqueId());
+
+        if (deathLocation.isPresent()) {
+            this.backService.teleportBack(target, PositionAdapter.convert(deathLocation.get()));


te dwie metody idealnie nadają się do serwisu a gettery można wywalić :D

Rollczi · 2025-10-26T21:45:51Z

...ore-core/src/main/java/com/eternalcode/core/feature/randomteleport/RandomTeleportConfig.java

        "# Specify world name to always teleport to that world"
    })
-    public String world = "world";
+    public String world = "world_nether";


hmm czemu tak?

vLuckyyy and others added 2 commits September 13, 2025 22:19

WIP permission for back on death.

ac0a158

Improve back logic

32bce4b

Jakubk15 requested review from CitralFlo, P1otrulla, Rollczi, igoyek, imDMK and vLuckyyy October 4, 2025 16:45

Jakubk15 self-assigned this Oct 4, 2025

Jakubk15 requested a review from a team as a code owner October 4, 2025 16:45

Jakubk15 added the 🔧 enhancement Enhances existing function label Oct 4, 2025

Merge branch 'master' into back-on-deatch-permission-wip

1b130ad

Jakubk15 changed the title ~~Extend /back functionality to per-death and per-teleport~~ GH-1192 Extend /back functionality to per-death and per-teleport Oct 4, 2025

gemini-code-assist bot reviewed Oct 4, 2025

View reviewed changes

Update eternalcore-core/src/main/java/com/eternalcode/core/configurat…

c733197

…ion/migrations/Migration_0010_Move_back_to_dedicated_section.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

imDMK requested changes Oct 5, 2025

View reviewed changes

Rollczi requested changes Oct 7, 2025

View reviewed changes

igoyek approved these changes Oct 8, 2025

View reviewed changes

vLuckyyy requested changes Oct 8, 2025

View reviewed changes

...eternalcode/core/configuration/migrations/Migration_0010_Move_back_to_dedicated_section.java Outdated Show resolved Hide resolved

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java Outdated Show resolved Hide resolved

P1otrulla removed their request for review October 9, 2025 09:49

CitralFlo reviewed Oct 11, 2025

View reviewed changes

Jakubk15 added 3 commits October 11, 2025 21:00

Adjust to others' suggestions

a2b33a8

Document tpaTimer to also work for /back command

043f190

Simplify if-else statement

98fc5f6

Jakubk15 requested review from Rollczi, imDMK and vLuckyyy October 11, 2025 19:06

Merge branch 'master' into back-on-deatch-permission-wip

d973b9c

Jakubk15 requested review from ChudziudgiToJa, P1otrulla, Pawelusze, Qbiterv, VerniQ, igoyek, imDMK and mydelkonivea and removed request for igoyek and imDMK October 18, 2025 16:29

vLuckyyy requested review from imDMK and removed request for ChudziudgiToJa, Pawelusze, Qbiterv, VerniQ and mydelkonivea October 18, 2025 22:42

P1otrulla approved these changes Oct 19, 2025

View reviewed changes

imDMK approved these changes Oct 19, 2025

View reviewed changes

CitralFlo approved these changes Oct 19, 2025

View reviewed changes

eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackService.java Outdated Show resolved Hide resolved

...e-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TeleportRequestConfig.java Outdated Show resolved Hide resolved

vLuckyyy requested changes Oct 20, 2025

View reviewed changes

Jakubk15 added 5 commits October 24, 2025 20:23

Adjust to others' suggestions (WIP)

75ea7fd

Remove unused imports

738ee16

Create a default executor for /back command

29b76e2

Add proper permission to BackCommand

16362d6

Reduce nesting level

8f7ffa1

Jakubk15 requested a review from vLuckyyy October 25, 2025 12:22

Jakubk15 added 2 commits October 25, 2025 14:30

Properly send a message to player when teleporting back

282c4bd

Fix ClassCastException

b41d2d4

Rollczi requested changes Oct 26, 2025

View reviewed changes

Uh oh!

GH-1192 Extend /back functionality to per-death and per-teleport #1192

Are you sure you want to change the base?

GH-1192 Extend /back functionality to per-death and per-teleport #1192

Conversation

Jakubk15 commented Oct 4, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rollczi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igoyek left a comment

Choose a reason for hiding this comment

Uh oh!

vLuckyyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jakubk15 commented Oct 9, 2025

Uh oh!

P1otrulla commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jakubk15 commented Oct 23, 2025

Uh oh!

Rollczi Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Rollczi Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants