Skip to content

Conversation

@RaFaeL-Cunha
Copy link

@RaFaeL-Cunha RaFaeL-Cunha commented Nov 9, 2025

Resolve o erro 'ON CONFLICT DO UPDATE command cannot affect row a second time' que ocorria ao importar histórico de contatos duplicados.

A correção remove a tentativa de atualizar o campo 'identifier' no ON CONFLICT, já que este campo faz parte da constraint de conflito e não pode ser atualizado.

Erro original:

  • identifier = EXCLUDED.identifier

Correção:

  • updated_at = NOW()

Isso permite que contatos duplicados sejam atualizados corretamente sem causar erro.

✅ Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have manually tested my changes thoroughly
  • I have verified the changes work with different scenarios
  • Any dependent changes have been merged and published

📝 Additional Notes

Minimal change (1 line) that fixes a critical bug. Low risk - only affects duplicate contact handling during import.

Summary by Sourcery

Fix duplicate contact import error in Chatwoot integration by adjusting the ON CONFLICT update clause to update only the timestamp.

Bug Fixes:

  • Remove identifier update in ON CONFLICT clause to avoid updating the same unique column twice
  • Update the updated_at field instead of identifier to resolve 'ON CONFLICT DO UPDATE command cannot affect row a second time' error during contact import

Resolve o erro 'ON CONFLICT DO UPDATE command cannot affect row a second time' que ocorria ao importar histórico de contatos duplicados.

A correção remove a tentativa de atualizar o campo 'identifier' no ON CONFLICT, já que este campo faz parte da constraint de conflito e não pode ser atualizado.

Erro original:
- identifier = EXCLUDED.identifier

Correção:
- updated_at = NOW()

Isso permite que contatos duplicados sejam atualizados corretamente sem causar erro.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the SQL upsert for contact imports to avoid updating a constrained field, replacing identifier updates with a timestamp refresh to eliminate duplicate key errors.

Entity relationship diagram for updated contact import upsert

erDiagram
    CONTACTS {
        string identifier PK
        string name
        string phone_number
        datetime updated_at
    }
    %% The upsert now updates 'updated_at' instead of 'identifier' on conflict
    %% 'identifier' is the primary key and conflict constraint
Loading

Class diagram for updated ChatwootImport contact upsert logic

classDiagram
    class ChatwootImport {
        +importContacts()
        -sqlInsert: string
        -bindInsert: any
    }
    ChatwootImport : importContacts() uses SQL upsert
    ChatwootImport : ON CONFLICT (identifier) DO UPDATE SET name, phone_number, updated_at
Loading

File-Level Changes

Change Details Files
Refined ON CONFLICT DO UPDATE clause to remove identifier update and refresh timestamp
  • Removed identifier = EXCLUDED.identifier
  • Added updated_at = NOW() in the DO UPDATE clause
src/api/integrations/chatbot/chatwoot/utils/chatwoot-import-helper.ts

Possibly linked issues

  • #N/A: PR fixes 'ON CONFLICT DO UPDATE' error by updating updated_at instead of identifier in SQL, resolving duplicate contact import.
  • #N/A: The PR fixes the exact 'ON CONFLICT' database error in chatwoot-import-helper.ts by changing the update clause from identifier to updated_at, which resolves the issue of incomplete contact import.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidsonGomes DavidsonGomes merged commit 90640b7 into EvolutionAPI:develop Nov 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants