Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `ReportActionUtils.ts` #78744

mananjadhav · 2026-01-01T01:40:14Z

Explanation of Change

Fixed Issues

$ #66408
PROPOSAL:

Tests

Added in QA steps.

Verify that no errors appear in the JS console

Offline tests

Same as QA steps.

QA Steps

Go to the App and start a new chat.
Enter any message in the composer and click send. Verify it's sent successfully.
Now edit the message and save. Verify it's saved successfully.
Next edit the message again, mention the current user and any other user.
Verify the message is edited successfully.
Next edit the message again, empty the text input.
Click on save, a delete comment modal should appear
Click on delete and verify the message is deleted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-edit-delete-comment-onyx-session.mov

codecov · 2026-01-01T01:49:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../pages/home/report/ReportActionItemMessageEdit.tsx	`56.50% <100.00%> (+0.39%)`	⬆️
src/libs/actions/Report.ts	`53.24% <66.66%> (-2.15%)`	⬇️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx	`42.10% <0.00%> (ø)`
src/libs/ReportActionsUtils.ts	`45.97% <71.42%> (-5.88%)`	⬇️
... and 163 files with indirect coverage changes

…emove-onyx-connect-1

melvin-bot · 2026-01-03T18:48:49Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2026-01-03T18:49:16Z

@DylanDylann Will review this PR

DylanDylann · 2026-01-05T08:52:24Z

@mananjadhav For testing, please pick a sample flow in to test steps and remove No QA label. There’s no need to test all flows related to these changes

DylanDylann · 2026-01-05T08:57:12Z

tests/actions/ReportTest.ts


        const {result: ancestors, rerender} = renderHook(() => useAncestors(originalReport));
-        Report.editReportComment(originalReport, newReportAction, ancestors.current, 'Testing an edited comment', undefined, undefined);
+        Report.editReportComment(originalReport, newReportAction, ancestors.current, 'Testing an edited comment', undefined, undefined, '');


Please adding a test case to make sure that the new param is working well. Thanks

…emove-onyx-connect-1

DylanDylann · 2026-01-07T03:22:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-01-07.at.10.23.16.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-01-07T16:17:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-08T16:49:23Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:18:21Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:14:43Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:21:39Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mananjadhav added 5 commits January 1, 2026 04:21

fix: rename variables to prefix deprecated

96788eb

fix: update the params for current user email usage

7e964b9

fix: add email param to deleteReportComment

8a42e1f

fix: update current email references

2d12bab

style: lint fixes

a21541d

melvin-bot bot assigned mananjadhav Jan 1, 2026

mananjadhav added 3 commits January 1, 2026 04:51

test: fix broken tests

93f50ca

refactor: rename variable

bf1a777

test: add unit test

b1d8c2d

mananjadhav changed the title ~~Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts~~ [No QA] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts Jan 1, 2026

mananjadhav added 5 commits January 1, 2026 05:23

test: fix broken jest test

51aeb2e

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-66408-r…

b845dce

…emove-onyx-connect-1

test: added tests

4eb6d4e

test: fix broken test

944b2eb

fix: remove unwanted code

24a88d1

mananjadhav marked this pull request as ready for review January 3, 2026 18:48

mananjadhav requested review from a team as code owners January 3, 2026 18:48

melvin-bot bot requested review from DylanDylann and JmillsExpensify and removed request for a team January 3, 2026 18:48

melvin-bot bot removed the request for review from a team January 3, 2026 18:48

DylanDylann reviewed Jan 5, 2026

View reviewed changes

mananjadhav changed the title ~~[No QA] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts~~ Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts Jan 6, 2026

mananjadhav added 2 commits January 7, 2026 02:27

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-66408-r…

fe535ac

…emove-onyx-connect-1

test: added test for email param

ec51395

mananjadhav requested a review from DylanDylann January 6, 2026 21:41

DylanDylann approved these changes Jan 7, 2026

View reviewed changes

melvin-bot bot requested a review from danieldoglas January 7, 2026 03:23

danieldoglas approved these changes Jan 7, 2026

View reviewed changes

danieldoglas merged commit 9bc9569 into Expensify:main Jan 7, 2026
32 of 33 checks passed

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

melvin-bot bot mentioned this pull request Jan 9, 2026

[Due for payment 2026-01-16] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/ReportActionsUtils.ts #66408

Open

Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts #78744

Remove Onyx.connect() for the key: ONYXKEYS.SESSION in ReportActionUtils.ts #78744

Conversation

mananjadhav commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 1, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 3, 2026

Uh oh!

mananjadhav commented Jan 3, 2026

Uh oh!

DylanDylann commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 7, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `ReportActionUtils.ts` #78744

Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `ReportActionUtils.ts` #78744

mananjadhav commented Jan 1, 2026 •

edited

Loading

codecov bot commented Jan 1, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Jan 5, 2026 •

edited

Loading

DylanDylann commented Jan 7, 2026 •

edited

Loading